[PATCH] ARM: tegra: cpuidle: Remove unused variables

[PATCH] ARM: tegra: cpuidle: Remove unused variables

[Thierry Reding]

Commit 0697598 ("ARM: tegra: cpuidle: remove useless initialization")
removes the last usage of the drv variable from the Tegra20, Tegra30 and
Tegra114 cpuidle drivers but forgot to remove the variable.

Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
---
 arch/arm/mach-tegra/cpuidle-tegra114.c | 1 -
 arch/arm/mach-tegra/cpuidle-tegra20.c  | 1 -
 arch/arm/mach-tegra/cpuidle-tegra30.c  | 1 -
 3 files changed, 3 deletions(-)

diff --git a/arch/arm/mach-tegra/cpuidle-tegra114.c b/arch/arm/mach-tegra/cpuidle-tegra114.c
index c527cff..d6bea18 100644
--- a/arch/arm/mach-tegra/cpuidle-tegra114.c
+++ b/arch/arm/mach-tegra/cpuidle-tegra114.c
@@ -37,7 +37,6 @@ int __init tegra114_cpuidle_init(void)
 	int ret;
 	unsigned int cpu;
 	struct cpuidle_device *dev;
-	struct cpuidle_driver *drv = &tegra_idle_driver;
 
 	ret = cpuidle_register_driver(&tegra_idle_driver);
 	if (ret) {
diff --git a/arch/arm/mach-tegra/cpuidle-tegra20.c b/arch/arm/mach-tegra/cpuidle-tegra20.c
index 7cb1d3a..a1d524d 100644
--- a/arch/arm/mach-tegra/cpuidle-tegra20.c
+++ b/arch/arm/mach-tegra/cpuidle-tegra20.c
@@ -220,7 +220,6 @@ int __init tegra20_cpuidle_init(void)
 	int ret;
 	unsigned int cpu;
 	struct cpuidle_device *dev;
-	struct cpuidle_driver *drv = &tegra_idle_driver;
 
 #ifdef CONFIG_PM_SLEEP
 	tegra_tear_down_cpu = tegra20_tear_down_cpu;
diff --git a/arch/arm/mach-tegra/cpuidle-tegra30.c b/arch/arm/mach-tegra/cpuidle-tegra30.c
index 3fa95df..a308a3d 100644
--- a/arch/arm/mach-tegra/cpuidle-tegra30.c
+++ b/arch/arm/mach-tegra/cpuidle-tegra30.c
@@ -152,7 +152,6 @@ int __init tegra30_cpuidle_init(void)
 	int ret;
 	unsigned int cpu;
 	struct cpuidle_device *dev;
-	struct cpuidle_driver *drv = &tegra_idle_driver;
 
 #ifdef CONFIG_PM_SLEEP
 	tegra_tear_down_cpu = tegra30_tear_down_cpu;
-- 
1.8.2

Re: [PATCH] ARM: tegra: cpuidle: Remove unused variables

[Daniel Lezcano]

On 04/15/2013 09:32 AM, Thierry Reding wrote:
> Commit 0697598 ("ARM: tegra: cpuidle: remove useless initialization")
> removes the last usage of the drv variable from the Tegra20, Tegra30 and
> Tegra114 cpuidle drivers but forgot to remove the variable.
> 
> Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
> ---

Hi Thierry,

thanks for the cleanup. Actually, that has been already fixed by the
patches:

http://www.spinics.net/lists/arm-kernel/msg237945.html
* [V3 patch 15/19] ARM: tegra: cpuidle: use init/exit common routine for
tegra3
 http://www.spinics.net/lists/arm-kernel/msg237945.html

* [V3 patch 11/19] ARM: tegra: cpuidle: use init/exit common routine
  http://www.spinics.net/lists/arm-kernel/msg237956.html

* [V3 patch 14/19] ARM: tegra: cpuidle: use init/exit common routine for
tegra2
  http://www.spinics.net/lists/arm-kernel/msg237965.html

Regards
  -- Daniel

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] ARM: tegra: cpuidle: Remove unused variables

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

On Mon, Apr 15, 2013 at 10:55:43AM +0200, Daniel Lezcano wrote:
> On 04/15/2013 09:32 AM, Thierry Reding wrote:
> > Commit 0697598 ("ARM: tegra: cpuidle: remove useless initialization")
> > removes the last usage of the drv variable from the Tegra20, Tegra30 and
> > Tegra114 cpuidle drivers but forgot to remove the variable.
> > 
> > Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
> > ---
> 
> Hi Thierry,
> 
> thanks for the cleanup. Actually, that has been already fixed by the
> patches:
> 
> http://www.spinics.net/lists/arm-kernel/msg237945.html
> * [V3 patch 15/19] ARM: tegra: cpuidle: use init/exit common routine for
> tegra3
>  http://www.spinics.net/lists/arm-kernel/msg237945.html
> 
> * [V3 patch 11/19] ARM: tegra: cpuidle: use init/exit common routine
>   http://www.spinics.net/lists/arm-kernel/msg237956.html
> 
> * [V3 patch 14/19] ARM: tegra: cpuidle: use init/exit common routine for
> tegra2
>   http://www.spinics.net/lists/arm-kernel/msg237965.html

I didn't see those for some reason. They apparently didn't make it to
the linux-tegra mailing list and I wasn't watching the others too
closely. Sorry for the noise.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]