From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prashant Gaikwad Subject: Re: [PATCH resend 1/2] clk: tegra: remove USB from clk init table Date: Wed, 17 Apr 2013 17:39:37 +0530 Message-ID: <516E9101.5050703@nvidia.com> References: <1366011105-2351-1-git-send-email-dev@lynxeye.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1366011105-2351-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lucas Stach Cc: Stephen Warren , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Peter De Schrijver , "mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Monday 15 April 2013 01:01 PM, Lucas Stach wrote: > The USB clocks are just clock gates, so no need to set a specific clock. > In fact trying to set a specific clock is just a NOP if the requested > clockrate is the same as those of the parent (clk_m) or will trigger a > WARN_ON() if rates don't match up. > > As we are not setting a specific rate, nor activating the clocks at > init, there is no point in keeping the the usb entries in the clock init > table. > > Signed-off-by: Lucas Stach > --- > Trace produced by system with 13MHz clk_m: Reviewed-by: Prashant Gaikwad > tegra_init_from_table: Failed to set rate 12000000 of usbd > ------------[ cut here ]------------ > WARNING: at drivers/clk/tegra/clk.c:64 > tegra_init_from_table+0xc0/0x158() > Modules linked in: > [] (unwind_backtrace+0x0/0xf8) from > [](warn_slowpath_common+0x4c/0x64) > [] (warn_slowpath_common+0x4c/0x64) from [] > (warn_slowpath_null+0x1c/0x24) > [] (warn_slowpath_null+0x1c/0x24) from [] > (tegra_init_from_table+0xc0/0x158) > [] (tegra_init_from_table+0xc0/0x158) from [] > (tegra20_clock_init+0x1398/0x13d4) > [] (tegra20_clock_init+0x1398/0x13d4) from [] > (of_clk_init+0x30/0x58) > [] (of_clk_init+0x30/0x58) from [] > (tegra_dt_init_irq+0x8/0x1c) > [] (tegra_dt_init_irq+0x8/0x1c) from [] > (init_IRQ+0x14/0x1c) > [] (init_IRQ+0x14/0x1c) from [] > (start_kernel+0x1a0/0x2f8) > [] (start_kernel+0x1a0/0x2f8) from [<0000807c>] (0x807c) > ---[ end trace 1b75b31a2719ed1c ]--- > --- > drivers/clk/tegra/clk-tegra20.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/clk/tegra/clk-tegra20.c b/drivers/clk/tegra/clk-tegra20.c > index f873dce..a73278f 100644 > --- a/drivers/clk/tegra/clk-tegra20.c > +++ b/drivers/clk/tegra/clk-tegra20.c > @@ -1259,9 +1259,6 @@ static __initdata struct tegra_clk_init_table init_table[] = { > {uartc, pll_p, 0, 0}, > {uartd, pll_p, 0, 0}, > {uarte, pll_p, 0, 0}, > - {usbd, clk_max, 12000000, 0}, > - {usb2, clk_max, 12000000, 0}, > - {usb3, clk_max, 12000000, 0}, > {pll_a, clk_max, 56448000, 1}, > {pll_a_out0, clk_max, 11289600, 1}, > {cdev1, clk_max, 0, 1},