linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>,
	"mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Peter De Schrijver
	<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Subject: Re: [PATCH resend 1/2] clk: tegra: remove USB from clk init table
Date: Wed, 17 Apr 2013 11:29:47 -0600	[thread overview]
Message-ID: <516EDC0B.1060105@wwwdotorg.org> (raw)
In-Reply-To: <1366011105-2351-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>

On 04/15/2013 01:31 AM, Lucas Stach wrote:
> The USB clocks are just clock gates, so no need to set a specific clock.
> In fact trying to set a specific clock is just a NOP if the requested
> clockrate is the same as those of the parent (clk_m) or will trigger a
> WARN_ON() if rates don't match up.
> 
> As we are not setting a specific rate, nor activating the clocks at
> init, there is no point in keeping the the usb entries in the clock init
> table.

Lucas, these two patches look good for me. I'm just waiting on Mike's
ack to forward them to arm-soc. If that doesn't happen today, feel free
to forward them to arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org when it does, with a note requesting
they be applied since I'm away on vacation. It might be useful for them
to know that they're best applied wherever Tegra's for-3.10/clk branch
was merged.

Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Tested-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

(Tested for regressions; I didn't actually test using the AC'97 clock,
since I don't have the HW)

  parent reply	other threads:[~2013-04-17 17:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15  7:31 [PATCH resend 1/2] clk: tegra: remove USB from clk init table Lucas Stach
     [not found] ` <1366011105-2351-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-04-15  7:31   ` [PATCH resend 2/2] clk: tegra: add ac97 controller clock Lucas Stach
     [not found]     ` <1366011105-2351-2-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-04-15 11:03       ` Peter De Schrijver
2013-04-17 12:17       ` Prashant Gaikwad
     [not found]         ` <516E92C7.6070700-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-17 15:11           ` Stephen Warren
2013-04-15 10:59   ` [PATCH resend 1/2] clk: tegra: remove USB from clk init table Peter De Schrijver
2013-04-15 17:47   ` Stephen Warren
     [not found]     ` <516C3D3A.7000508-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-17 12:14       ` Prashant Gaikwad
     [not found]         ` <516E9222.4080506-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-17 15:10           ` Stephen Warren
2013-04-17 12:09   ` Prashant Gaikwad
2013-04-17 17:29   ` Stephen Warren [this message]
     [not found]     ` <516EDC0B.1060105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-04-17 19:48       ` Mike Turquette
2013-04-18  6:46       ` Olof Johansson
2013-05-06 21:05       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516EDC0B.1060105@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).