From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH resend 1/2] clk: tegra: remove USB from clk init table Date: Wed, 17 Apr 2013 11:29:47 -0600 Message-ID: <516EDC0B.1060105@wwwdotorg.org> References: <1366011105-2351-1-git-send-email-dev@lynxeye.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1366011105-2351-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lucas Stach , "mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Peter De Schrijver , Olof Johansson , Arnd Bergmann List-Id: linux-tegra@vger.kernel.org On 04/15/2013 01:31 AM, Lucas Stach wrote: > The USB clocks are just clock gates, so no need to set a specific clock. > In fact trying to set a specific clock is just a NOP if the requested > clockrate is the same as those of the parent (clk_m) or will trigger a > WARN_ON() if rates don't match up. > > As we are not setting a specific rate, nor activating the clocks at > init, there is no point in keeping the the usb entries in the clock init > table. Lucas, these two patches look good for me. I'm just waiting on Mike's ack to forward them to arm-soc. If that doesn't happen today, feel free to forward them to arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org when it does, with a note requesting they be applied since I'm away on vacation. It might be useful for them to know that they're best applied wherever Tegra's for-3.10/clk branch was merged. Acked-by: Stephen Warren Tested-by: Stephen Warren (Tested for regressions; I didn't actually test using the AC'97 clock, since I don't have the HW)