From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "djbw-b10kYP2dOMg@public.gmane.org"
<djbw-b10kYP2dOMg@public.gmane.org>,
"swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] dma: tegra: implement suspend/resume callbacks
Date: Tue, 30 Apr 2013 18:12:32 +0530 [thread overview]
Message-ID: <517FBC38.3000108@nvidia.com> (raw)
In-Reply-To: <20130430103046.GD1960-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Tuesday 30 April 2013 04:00 PM, Vinod Koul wrote:
> On Wed, Apr 24, 2013 at 03:24:27PM +0530, Laxman Dewangan wrote:
>> +
>> + /* Enable clock before accessing register */
>> + ret = tegra_dma_runtime_resume(dev);
>> + if (ret < 0)
>> + return ret;
> You dont seem to handle suspend when DMA is active? Otherwise looks fine.
> Stephen, you okay with this patch?
The client of dma need to gracefully stop the transfer and then do
suspend himself.
Also driver suspend can happen even if there is no allocation of dma. In
this case, clock is disabled so enabling explicitly here.
next prev parent reply other threads:[~2013-04-30 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 9:54 [PATCH] dma: tegra: implement suspend/resume callbacks Laxman Dewangan
[not found] ` <1366797267-29567-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-30 10:30 ` Vinod Koul
[not found] ` <20130430103046.GD1960-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-04-30 12:42 ` Laxman Dewangan [this message]
2013-05-02 18:42 ` Stephen Warren
[not found] ` <5182B396.308-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-05-03 3:50 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517FBC38.3000108@nvidia.com \
--to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=djbw-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).