[PATCH] gpu: host1x: disable host1x on multiplatform if Tegra is not selected

[PATCH] gpu: host1x: disable host1x on multiplatform if Tegra is not selected

[Marc Dietrich]

host1x needs Tegra clock support which is only enabled if ARCH_TEGRA
is selected.

Cc: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: Terje Bergstrom <tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
---
 drivers/gpu/host1x/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
index ccfd42b..f139eaf 100644
--- a/drivers/gpu/host1x/Kconfig
+++ b/drivers/gpu/host1x/Kconfig
@@ -1,6 +1,6 @@
 config TEGRA_HOST1X
 	tristate "NVIDIA Tegra host1x driver"
-	depends on ARCH_TEGRA || ARCH_MULTIPLATFORM
+	depends on ARCH_TEGRA
 	help
 	  Driver for the NVIDIA Tegra host1x hardware.
 
-- 
1.7.9.5

Re: [PATCH] gpu: host1x: disable host1x on multiplatform if Tegra is not selected

[Stephen Warren]

On 05/22/2013 02:07 PM, Marc Dietrich wrote:
> host1x needs Tegra clock support which is only enabled if ARCH_TEGRA
> is selected.

You should send this patch to the drives/gpu maintainer and mailing list
(although perhaps Thierry sends pull requests for host1x?). And probably
explain why it's necessary.

Re: [PATCH] gpu: host1x: disable host1x on multiplatform if Tegrais not selected

[Marc Dietrich]

Am Mittwoch, 22. Mai 2013, 14:10:32 schrieb Stephen Warren:
> On 05/22/2013 02:07 PM, Marc Dietrich wrote:
> > host1x needs Tegra clock support which is only enabled if ARCH_TEGRA
> > is selected.
> 
> You should send this patch to the drives/gpu maintainer and mailing list
> (although perhaps Thierry sends pull requests for host1x?). And probably
> explain why it's necessary.

Well, there is no drivers/gpu maintainer, maybe you meant drivers/gpu/drm, but 
I don't know if host1x fits there. What's unclear in the patch description?

Marc

Re: [PATCH] gpu: host1x: disable host1x on multiplatform if Tegrais not selected

[Stephen Warren]

On 05/22/2013 02:24 PM, Marc Dietrich wrote:
> Am Mittwoch, 22. Mai 2013, 14:10:32 schrieb Stephen Warren:
>> On 05/22/2013 02:07 PM, Marc Dietrich wrote:
>>> host1x needs Tegra clock support which is only enabled if ARCH_TEGRA
>>> is selected.
>>
>> You should send this patch to the drives/gpu maintainer and mailing list
>> (although perhaps Thierry sends pull requests for host1x?). And probably
>> explain why it's necessary.
> 
> Well, there is no drivers/gpu maintainer, maybe you meant drivers/gpu/drm, but 
> I don't know if host1x fits there. What's unclear in the patch description?

It looks like the MAINTAINERS entry wasn't updated when the host1x code
was added, and drivers/gpu/drm/tegra moved to drivers/gpu/host1x. I
guess Thierry is applying patches for this directory.

The commit description would typically mention the compile error that
this solves and/or exactly why Tegra clock support is needed, rather
than just the clock core which would typically provide all the APIs
drivers need.

Re: [PATCH] gpu: host1x: disable host1x on multiplatform if Tegra is not selected

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

On Wed, May 22, 2013 at 02:10:32PM -0600, Stephen Warren wrote:
> On 05/22/2013 02:07 PM, Marc Dietrich wrote:
> > host1x needs Tegra clock support which is only enabled if ARCH_TEGRA
> > is selected.
> 
> You should send this patch to the drives/gpu maintainer and mailing list
> (although perhaps Thierry sends pull requests for host1x?). And probably
> explain why it's necessary.

It looks like Dave Airlie is expecting me to send pull requests, so
patches for everything below drivers/gpu/host1x should go to me. Please
also Cc dri-devel and Terje (especially for patches that touch host1x
code).

Since there had been some fallout during the 3.10 merge window I'm in
the process of setting up an "official" tree for tegra-drm (and host1x)
and have it go through linux-next to catch potential issues earlier. I
will make a mental note to update MAINTAINERS to reflect this once the
tree is set up.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]