From: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "cbou-JGs/UdohzUI@public.gmane.org"
<cbou-JGs/UdohzUI@public.gmane.org>,
"dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org"
<dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/1] tps65090-charger: Fix AC detect
Date: Fri, 7 Jun 2013 12:07:39 -0400 [thread overview]
Message-ID: <51B2054B.7030609@nvidia.com> (raw)
In-Reply-To: <1370553163-31804-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 6/6/2013 5:12 PM, Andrew Chew wrote:
> The VACG interrupt was not being enabled. Thus, interrupts were never
> generated when AC status changes. In addition, interrupts were never
> cleared after taking and processing the interrupt.
>
> Added the register offset for the INTR_MASK register, since this is needed
> to unmask the VACG interrupt.
>
> Enabled the VACG interrupt in tps65090_config_charger().
>
> Cleared interrupts after processing, in tps65090_charger_isr().
>
> Also removed unused variable "enable" in tps65090_enable_charging(),
> and fixed a typo in one of the dev_err() prints.
>
> Signed-off-by: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
Great! Tested and it works great on my Dalmore.
Tested-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Acked-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
-rhyland
--
nvpublic
next prev parent reply other threads:[~2013-06-07 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 21:12 [PATCH 1/1] tps65090-charger: Fix AC detect Andrew Chew
[not found] ` <1370553163-31804-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-07 16:07 ` Rhyland Klein [this message]
[not found] ` <51B2054B.7030609-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-06-09 17:03 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B2054B.7030609@nvidia.com \
--to=rklein-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=cbou-JGs/UdohzUI@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox