From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mfd: tps6586x: correct device name of the regulator cell
Date: Mon, 10 Jun 2013 14:12:38 -0600 [thread overview]
Message-ID: <51B63336.6000007@wwwdotorg.org> (raw)
In-Reply-To: <89e4451e14f324d8bd480f843fa5960b481e3188.1370894247.git.marvin24-Mmb7MZpHnFY@public.gmane.org>
On 06/10/2013 02:06 PM, Marc Dietrich wrote:
> Change the device name of the regulator function to the one chosed for
nit: s/chosed/chosen/
> MODULE_ALIAS. This fixes kernel module loading for the regulator function.
Not "loading" but "auto-loading" (based on a match of the MODULE_ALIAS
name).
> Also change the name of the platform driver to make everything consistent.
In this case, not really for consistency; if you didn't do that, it
simply wouldn't match the entry in tps6586x_cell[], so even with the
module loaded, the driver wouldn't get probed.
next prev parent reply other threads:[~2013-06-10 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 20:06 [PATCH] mfd: tps6586x: correct device name of the regulator cell Marc Dietrich
[not found] ` <89e4451e14f324d8bd480f843fa5960b481e3188.1370894247.git.marvin24-Mmb7MZpHnFY@public.gmane.org>
2013-06-10 20:12 ` Stephen Warren [this message]
2013-06-11 12:00 ` [PATCH v2] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B63336.6000007@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox