From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] USB: EHCI: tegra: Fix oops in error cleanup Date: Fri, 14 Jun 2013 09:40:58 -0600 Message-ID: <51BB398A.2040904@wwwdotorg.org> References: <1371208881-26916-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1371208881-26916-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Greg Kroah-Hartman , Alan Stern , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Venu Byravarasu List-Id: linux-tegra@vger.kernel.org On 06/14/2013 05:21 AM, Thierry Reding wrote: > Under some circumstances it happens that the connected PHY can't be > powered up properly, in which case the cleanup path currently crashes > because it checks the tegra->transceiver field using !IS_ERR(), which > will succeed because it is in fact NULL. Dereferencing that pointer > causes an oops in tegra_ehci_probe(). > > This patch fixes the issue by adding an additional label into the > cleanup path to separately take down the PHY and the transceiver. Reviewed-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html