From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/1] ARM: tegra: Add basic support for carma devkit Date: Thu, 27 Jun 2013 11:51:20 -0600 Message-ID: <51CC7B98.5090103@wwwdotorg.org> References: <1371994685-4997-1-git-send-email-chris.desjardins@amscins.com> <51CC6F83.2010606@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51CC6F83.2010606-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eric Brower Cc: Chris Desjardins , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Thierry Reding List-Id: linux-tegra@vger.kernel.org On 06/27/2013 10:59 AM, Eric Brower wrote: > On 06/23/2013 06:38 AM, Chris Desjardins wrote: >> >> Signed-off-by: Chris Desjardins >> --- >> arch/arm/boot/dts/tegra30-carma.dts | 461 >> +++++++++++++++++++++++++++++++++++ >> 1 file changed, 461 insertions(+) >> create mode 100644 arch/arm/boot/dts/tegra30-carma.dts >> >> diff --git a/arch/arm/boot/dts/tegra30-carma.dts >> b/arch/arm/boot/dts/tegra30-carma.dts >> new file mode 100644 >> index 0000000..e88134e >> --- /dev/null >> +++ b/arch/arm/boot/dts/tegra30-carma.dts >> @@ -0,0 +1,461 @@ >> +/dts-v1/; >> +#include "tegra30.dtsi" >> + >> +/** >> + * This file contains common DT entry for Carma >> + */ >> + >> +/ { >> + model = "NVIDIA Tegra30 Carma evaluation board"; >> + compatible = "nvidia,carma", "nvidia,tegra30"; > > Chris, > > This is not an NVIDIA board, it's a Seco board. I'd suggest: > > model = "Seco Tegra30 Carma development board"; > compatible = "seco,carma", "nvidia,tegra30"; > > But you might want to check with Seco regarding preference of prefix for > "seco,carma" above. I see no precedent for it after a quick check. That's a good point. The seco prefix should be added to Documentation/devicetree/bindings/vendor-prefixes.txt. I believe the rule for vendor prefixes is to use the company's stock ticker symbol if there is one and it makes sense, else fall back to name. "seco" is short enough it's probably fine either way.