public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH tegra-cbootimage-configs] Add Toradex Colibri T20 configurations
Date: Tue, 02 Jul 2013 09:31:57 -0600	[thread overview]
Message-ID: <51D2F26D.4000405@wwwdotorg.org> (raw)
In-Reply-To: <1372451264-13049-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>

On 06/28/2013 02:27 PM, Lucas Stach wrote:
> The Colibri T20 COM comes in two different versions, which can both
> boot from NAND or SD-Card.

> diff --git a/tegra20/toradex/colibri-t20/colibri-t20_256_hsmmc.bct.cfg b/tegra20/toradex/colibri-t20/colibri-t20_256_hsmmc.bct.cfg
...
> +OdmData       = 0x200C0000;

> diff --git a/tegra20/toradex/colibri-t20/colibri-t20_512_hsmmc.bct.cfg b/tegra20/toradex/colibri-t20/colibri-t20_512_hsmmc.bct.cfg
...
> +OdmData       = 0x400C0000;

Those ODMDATA values don't look correct. The first nibble should be set
as follows:

1: 256MiB
2: 512MiB
3: 1GiB

... and I assume that the "256" and "515" in the filenames represent the
RAM size?

Nit: Many files have an extra blank line at the end.

  parent reply	other threads:[~2013-07-02 15:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 20:27 [PATCH tegra-cbootimage-configs] Add Toradex Colibri T20 configurations Lucas Stach
     [not found] ` <1372451264-13049-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-06-28 22:25   ` Stephen Warren
     [not found]     ` <51CE0D43.2020508-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-06-29  8:16       ` Lucas Stach
2013-07-01 15:25         ` Stephen Warren
2013-07-02 15:31   ` Stephen Warren [this message]
     [not found]     ` <51D2F26D.4000405-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-15 18:30       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D2F26D.4000405@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox