From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
MLongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org,
linux-kernel-u79uwXL29TZX6JHB/w77yyCwEArCW2h5@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] hwmon: (lm90) add support to handle irq
Date: Mon, 08 Jul 2013 09:46:41 -0600 [thread overview]
Message-ID: <51DADEE1.1030408@wwwdotorg.org> (raw)
In-Reply-To: <20130705194728.GA24946-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
On 07/05/2013 01:47 PM, Guenter Roeck wrote:
> On Fri, Jul 05, 2013 at 11:35:05AM -0600, Stephen Warren wrote:
>> On 07/04/2013 01:57 AM, Wei Ni wrote:
>>> Add support to handle irq. When the temperature touch
>>> the limit value, the driver can handle the interrupt.
>>
>>> + if (client->irq >= 0) {
>>
>> 0 isn't a valid IRQ, so you can write that as simply if (client->irq).
>>
> If I recall correctly, it is valid on some platforms.
I thought ARM (just some ARM sub-architectures?) might have been the
last architecture, and even irrespective of that, we were trying not to
introduce any new code that relies on this strangeness, so it doesn't
propagate?
next prev parent reply other threads:[~2013-07-08 15:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 7:57 [PATCH 0/3] Lm90 Enhancements Wei Ni
[not found] ` <1372924670-16355-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-04 7:57 ` [PATCH 1/3] hwmon: (lm90) split set&show temp as common codes Wei Ni
2013-07-04 7:57 ` [PATCH 2/3] hwmon: (lm90) add support to handle irq Wei Ni
[not found] ` <1372924670-16355-3-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-05 17:35 ` Stephen Warren
[not found] ` <51D703C9.1060607-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-05 19:47 ` Guenter Roeck
[not found] ` <20130705194728.GA24946-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-07-08 15:46 ` Stephen Warren [this message]
[not found] ` <51DADEE1.1030408-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-08 20:06 ` Guenter Roeck
[not found] ` <20130708200623.GA1506-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-07-09 7:54 ` Wei Ni
2013-07-09 6:15 ` Thierry Reding
2013-07-09 6:49 ` Jean Delvare
2013-07-09 7:58 ` Wei Ni
2013-07-04 7:57 ` [PATCH 3/3] hwmon: (lm90) use enums for the indexes of temp8 and temp11 Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DADEE1.1030408@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=MLongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TZX6JHB/w77yyCwEArCW2h5@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox