From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 2/3] hwmon: (lm90) add support to handle irq Date: Mon, 08 Jul 2013 09:46:41 -0600 Message-ID: <51DADEE1.1030408@wwwdotorg.org> References: <1372924670-16355-1-git-send-email-wni@nvidia.com> <1372924670-16355-3-git-send-email-wni@nvidia.com> <51D703C9.1060607@wwwdotorg.org> <20130705194728.GA24946@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130705194728.GA24946-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Guenter Roeck Cc: Wei Ni , khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, MLongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, linux-kernel-u79uwXL29TZX6JHB/w77yyCwEArCW2h5@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 07/05/2013 01:47 PM, Guenter Roeck wrote: > On Fri, Jul 05, 2013 at 11:35:05AM -0600, Stephen Warren wrote: >> On 07/04/2013 01:57 AM, Wei Ni wrote: >>> Add support to handle irq. When the temperature touch >>> the limit value, the driver can handle the interrupt. >> >>> + if (client->irq >= 0) { >> >> 0 isn't a valid IRQ, so you can write that as simply if (client->irq). >> > If I recall correctly, it is valid on some platforms. I thought ARM (just some ARM sub-architectures?) might have been the last architecture, and even irrespective of that, we were trying not to introduce any new code that relies on this strangeness, so it doesn't propagate?