public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH V2] ARM: tegra: enable palmas device for dalmore
Date: Mon, 15 Jul 2013 13:29:45 -0400	[thread overview]
Message-ID: <51E43189.5050805@nvidia.com> (raw)
In-Reply-To: <51E43129.7080602-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 7/15/2013 1:28 PM, Laxman Dewangan wrote:
> On Monday 15 July 2013 10:18 PM, Stephen Warren wrote:
>> On 07/10/2013 01:37 AM, Laxman Dewangan wrote:
>>> Make the entry of Dalmore Power Management Unit device TPS65913
>>> in dalmore DTS file. The Palma driver support this device.
>>>
>>> Enable following submodule of the TPS65913:
>>> - GPIO driver
>>> - RTC driver.
>>> - Power regulator driver.
>> If I apply this, (at least) the SD card no longer works. I assume the
>> regulator for it is being turned off somehow.
> 
> As per downstream power tree, smps9 is feeding power to sd slot and I 
> make this rail as always ON. So there should not be any issue.
> 
> Rhyland,
> Do you see any differences on this power tree with your power tree with 
> DT? There was discussion sometime ago on the sdcard. Am I missing 
> anything here?
> 
> Thanks,
> Laxman
> 


I noticed a couple differences between this and what we are using...

Yours:
+			    ldo8-in-supply = <&tps65090_dcdc3_reg>;
+			    ldo9-in-supply = <&palmas_smps9_reg>;
Ours:
                            ldo8-in-supply = <&tps65090_dcdc2_reg>;
                            ldo9-in-supply = <&tps65090_dcdc2_reg>;

We also specify supplies (floating) for smps6 and smps10.  I don't think
that matters though.

Also we have the vmmc-supply and sd-slot-supply propeties set for the sd
card slot, like so:

                vmmc-supply = <&palmas_smps3_reg>;
                sd-slot-supply = <&palmas_smps9_reg>;

Also, we have the interrupt trigger mode different for the palmas:

Yours:
+			interrupts = <0 86 0x4>;
Ours:
                        interrupts = <0 86 0x8>;


I think other than that they should be the same.

-Rhyland

-- 
nvpublic

  parent reply	other threads:[~2013-07-15 17:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10  7:37 [PATCH V2] ARM: tegra: enable palmas device for dalmore Laxman Dewangan
     [not found] ` <1373441852-27176-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-15 16:48   ` Stephen Warren
     [not found]     ` <51E427D6.7090702-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-15 17:28       ` Laxman Dewangan
     [not found]         ` <51E43129.7080602-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-15 17:29           ` Rhyland Klein [this message]
2013-07-16 13:51   ` Mikko Perttunen
     [not found]     ` <51E54FD1.1010404-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-17  8:57       ` Laxman Dewangan
     [not found]         ` <51E65C74.8060405-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-17  8:53           ` Mikko Perttunen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E43189.5050805@nvidia.com \
    --to=rklein-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox