From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114. Date: Tue, 16 Jul 2013 19:14:48 +0800 Message-ID: <51E52B28.9090708@nvidia.com> References: <1373615364-18559-1-git-send-email-wni@nvidia.com> <51E427F1.9010106@wwwdotorg.org> <51E42DB0.8090006@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51E42DB0.8090006-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: "khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org" , "linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org" , "thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 07/16/2013 01:13 AM, Stephen Warren wrote: > On 07/15/2013 10:48 AM, Stephen Warren wrote: >> On 07/12/2013 01:49 AM, Wei Ni wrote: >>> Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore. >> >> I have applied the series to Tegra's for-3.12/dt branch. > > Actually, I see the following on Dalmore (although Cardhu works): > > [ 29.448539] lm90 0-004c: Register 0x4 read failed (-121) > [ 29.453930] lm90 0-004c: Failed to read convrate register! > [ 29.460034] lm90 0-004c: Register 0x3 read failed (-121) > [ 29.465408] lm90 0-004c: Initialization failed! > > So, there's something wrong here, and I've dropped the patch for > Dalmore. Does this patch actually work for you? > I test it with the Chrome u-boot, the lm90 works fine. But today, if I tried to use the uboot from git://git.denx.de/u-boot-tegra.git, I can repo your errors, it seems the i2c can't work, the lm90 driver read register failed. I traced it, but can't find the root cause yet.