From: Mikko Perttunen <mperttunen@nvidia.com>
To: Wei Ni <wni@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114.
Date: Wed, 17 Jul 2013 11:23:54 +0300 [thread overview]
Message-ID: <51E6549A.1010006@nvidia.com> (raw)
In-Reply-To: <51E65309.6000101@nvidia.com>
On 07/17/2013 11:17 AM, Wei Ni wrote:
> On 07/16/2013 07:14 PM, Wei Ni wrote:
>> On 07/16/2013 01:13 AM, Stephen Warren wrote:
>>> On 07/15/2013 10:48 AM, Stephen Warren wrote:
>>>> On 07/12/2013 01:49 AM, Wei Ni wrote:
>>>>> Enable thermal sensor lm90 for Tegra30 Cardhu and Tegra114 Dalmore.
>>>>
>>>> I have applied the series to Tegra's for-3.12/dt branch.
>>>
>>> Actually, I see the following on Dalmore (although Cardhu works):
>>>
>>> [ 29.448539] lm90 0-004c: Register 0x4 read failed (-121)
>>> [ 29.453930] lm90 0-004c: Failed to read convrate register!
>>> [ 29.460034] lm90 0-004c: Register 0x3 read failed (-121)
>>> [ 29.465408] lm90 0-004c: Initialization failed!
>>>
>>> So, there's something wrong here, and I've dropped the patch for
>>> Dalmore. Does this patch actually work for you?
>>>
>> I test it with the Chrome u-boot, the lm90 works fine.
>> But today, if I tried to use the uboot from
>> git://git.denx.de/u-boot-tegra.git, I can repo your errors, it seems the
>> i2c can't work, the lm90 driver read register failed.
>> I traced it, but can't find the root cause yet.
>
> Hi, Stephen
> I found the root cause.
> In the Chrome u-boot, it will turn on the regulator for the lm90, but in
> the upstream u-boot, it didn't do it.
> I think this regulator should be handled in the kernel driver, but it
> seems the regulator palmas tps65913 didn't be supported on the dalmore yet.
> So may be we have to wait the palmas ready on dalmore.
A patch to enable tps65913 on dalmore has already been posted a couple
of days
ago by Laxman Dewangan, so this shouldn't be too problematic.
>
> Do you have any suggestions?
>
> Thanks.
> Wei.
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-07-17 8:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 7:49 [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114 Wei Ni
2013-07-12 7:49 ` [PATCH v3 1/2] ARM: dt: t30 cardhu: add dt entry for nct1008 Wei Ni
2013-07-12 7:49 ` [PATCH v3 2/2] ARM: dt: t114 dalmore: " Wei Ni
[not found] ` <1373615364-18559-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-15 16:48 ` [PATCH v3 0/2] Enable lm90 in Tegra30 and Tegra114 Stephen Warren
[not found] ` <51E427F1.9010106-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-15 17:13 ` Stephen Warren
[not found] ` <51E42DB0.8090006-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-16 11:14 ` Wei Ni
[not found] ` <51E52B28.9090708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-17 8:17 ` Wei Ni
2013-07-17 8:23 ` Mikko Perttunen [this message]
[not found] ` <51E6549A.1010006-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-07-17 9:08 ` Wei Ni
2013-07-17 17:05 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E6549A.1010006@nvidia.com \
--to=mperttunen@nvidia.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox