From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] ASoC: tegra: depend on ARCH_TEGRA, not ARCH_TEGRA_*
Date: Wed, 17 Jul 2013 11:01:30 -0600 [thread overview]
Message-ID: <51E6CDEA.7060003@wwwdotorg.org> (raw)
In-Reply-To: <20130717083003.GA22506-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 07/17/2013 02:30 AM, Mark Brown wrote:
> On Tue, Jul 16, 2013 at 04:27:47PM -0600, Stephen Warren wrote:
>
>> Stop selecting I2S/AC97/SPDIF controller drivers from the machine
>> driver config options; this doesn't really work if we don't know
>> which specific SoC(s) we're building for. However, set their
>> default values based on SND_SOC_TEGRA, since most people will
>> probably want to enable support for all SoCs. This also avoids
>> the need to change any defconfig files.
>
> This doesn't seem terribly clever and is definitely not idiomatic
> for ASoC. If you want to just select all CPUs that'd be fine but
> forcing the user to select the individual components isn't the
> style anything else uses.
So I think what you're saying is that machine drivers should be
changed like:
- select SND_SOC_TEGRA20_I2S if ARCH_TEGRA_2x_SOC
- select SND_SOC_TEGRA30_I2S if ARCH_TEGRA_3x_SOC
+ select SND_SOC_TEGRA20_I2S
+ select SND_SOC_TEGRA30_I2S
But then, it won't be possible to disable support for older SoCs,
since simply enabling a machine driver that might support Tegra20
would force ASoC support for Tegra20 to be enabled, even if the user
only cares about Tegra30.
next prev parent reply other threads:[~2013-07-17 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 22:27 [PATCH] ASoC: tegra: depend on ARCH_TEGRA, not ARCH_TEGRA_* Stephen Warren
[not found] ` <1374013667-21435-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-17 8:30 ` Mark Brown
[not found] ` <20130717083003.GA22506-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-17 17:01 ` Stephen Warren [this message]
2013-07-17 17:57 ` Mark Brown
2013-07-17 18:23 ` Stephen Warren
[not found] ` <51E6E107.8020300-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-17 22:33 ` Mark Brown
[not found] ` <20130717223309.GZ22506-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-17 22:52 ` Stephen Warren
[not found] ` <51E7203A.2020007-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-07-18 9:58 ` Mark Brown
[not found] ` <20130718095815.GE22506-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-07-18 16:58 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E6CDEA.7060003@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox