From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V2] ARM: dts: tegra114: dalmore: fix the irq trigger type of Palmas MFD device Date: Fri, 26 Jul 2013 09:16:36 -0600 Message-ID: <51F292D4.9030208@wwwdotorg.org> References: <1374663272-9937-1-git-send-email-josephl@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1374663272-9937-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joseph Lo Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Laxman Dewangan List-Id: linux-tegra@vger.kernel.org On 07/24/2013 04:54 AM, Joseph Lo wrote: > The IRQ trigger type of Palmas MFD device (tps65913) is edge trigger. The > wrong configuration would cause an interrupt storm when booting the > system. Fixing it in DT with appropriate interrupt type. > diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts > palmas: tps65913 { > compatible = "ti,palmas"; > reg = <0x58>; > - interrupts = <0 86 0x4>; > + interrupts = <0 86 0x0>; The legal values for that final cell are: - bits[3:0] trigger type and level flags 1 = low-to-high edge triggered 2 = high-to-low edge triggered 4 = active high level-sensitive 8 = active low level-sensitive 0 isn't one of those values. This patch can't be correct. BTW, this cell should use the constants from .