From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2 1/3] hwmon: (lm90) Add power control Date: Thu, 08 Aug 2013 14:30:10 -0700 Message-ID: <52040DE2.50201@roeck-us.net> References: <1375944991-29182-1-git-send-email-wni@nvidia.com> <1375944991-29182-2-git-send-email-wni@nvidia.com> <20130808110136.GA6427@sirena.org.uk> <52038035.7030803@roeck-us.net> <20130808130840.GC6427@sirena.org.uk> <5203B78C.7010101@roeck-us.net> <20130808171554.GI6427@sirena.org.uk> <20130808200026.GA18226@roeck-us.net> <20130808211825.GN6427@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130808211825.GN6427-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Wei Ni , swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, MLongnecker-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 08/08/2013 02:18 PM, Mark Brown wrote: > On Thu, Aug 08, 2013 at 01:00:26PM -0700, Guenter Roeck wrote: >> On Thu, Aug 08, 2013 at 06:15:54PM +0100, Mark Brown wrote: > >>> Sure, that's the transition issues I mentioned - the regulator API does >>> have stubbing facilities which should cover things and it's very easy to >>> define stub regulators if you need to. Like I say I expect this to be a >>> lot easier after the next merge window as another way of doing stubs is >>> being added which should make this even easier by avoiding disrupting >>> drivers that do genuinely want to check for absent supplies and handle >>> that better. > >> We will need to make sure that all dts files using any of the compatible chips >> are updated accordingly. There are several entries in various dts files for >> adm1032, adt7461, lm90, and nct1008. > > Yes, and probably also board files as well. Or either just accept > bisection trouble for now or wait till the better stubbing is in there - Ah, that is exactly the trouble I wanted to avoid. > that will mean that for DT systems the core will just assume the supply > is really there and not fail requests if it's not in the DT. > >>> The names requested by a driver are defined with regard to the device >>> and should be the names used by the chip itself as defined in the > >> 9 votes for vdd, 11 votes for vcc, one undecided (no datasheet available). >> Guess one is as good as the other ;-). > > What I've suggested before is to use the name from the part for which > the driver is named. Assuming the vendor doesn't randomly change their > datasheet (but that causes problems for hardware engineers so tends to > be avoided). > Makes sense. Guenter