Re: [cbootimage PATCH 1/1] Add Tegra124 support

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 08/23/2013 01:05 PM, Stephen Warren wrote:
> On 08/22/2013 09:46 PM, Penny Chiu wrote:
>> Add the Tegra124 chip support to cbootimage. User can use "-t124" as
>> option to parse .cfg and generate BCT/image for Tegra124.
> 
> This looks fine to me at a quick glance. Just one small comment below:
> 
>> diff --git a/src/cbootimage.c b/src/cbootimage.c
> 
>>  	printf("Usage: cbootimage [options] configfile imagename\n");
>>  	printf("    options:\n");
>> -	printf("    -h, --help, -?        Display this message.\n");
>> -	printf("    -d, --debug           Output debugging information.\n");
>> -	printf("    -gbct                 Generate the new bct file.\n");
>> -	printf("    -o<ODM_DATA>          Specify the odm_data(in hex).\n");
>> -	printf("    [-t20|-t30|-t114]     Select one of the possible target devices,\n");
>> -	printf("                          -t20 if unspecified.\n");
>> -	printf("    configfile            File with configuration information\n");
>> -	printf("    imagename             Output image name\n");
>> +	printf("    -h, --help, -?              Display this message.\n");
>> +	printf("    -d, --debug                 Output debugging information.\n");
>> +	printf("    -gbct                       Generate the new bct file.\n");
>> +	printf("    -o<ODM_DATA>                Specify the odm_data(in hex).\n");
>> +	printf("    [-t20|-t30|-t114|-t124]     Select one of the possible target devices,\n");
>> +	printf("                                -t20 if unspecified.\n");
>> +	printf("    configfile                  File with configuration information\n");
>> +	printf("    imagename                   Output image name\n");
>>  }
> 
> To avoid continually re-formatting that text when adding new SoCs, why
> not start the description of the -tNN options on a separate line, and
> leave the indentation as-is for all the unmodified lines. i.e.:
> 
>>> +	printf("    [-t20|-t30|-t114|-t124]\n");
>>> +	printf("                          Select one of the possible target devices,\n");
>>> +	printf("                          -t20 if unspecified.\n");

I've pushed out the patch with this change included.