From: Stephen Warren <swarren@wwwdotorg.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Mike Turquette <mturquette@linaro.org>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
Joseph Lo <josephl@nvidia.com>,
Paul Walmsley <pwalmsley@nvidia.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 05/12] clk: tegra: add header for common tegra clock IDs
Date: Mon, 23 Sep 2013 12:05:23 -0600 [thread overview]
Message-ID: <524082E3.8070801@wwwdotorg.org> (raw)
In-Reply-To: <1379515331-19427-6-git-send-email-pdeschrijver@nvidia.com>
On 09/18/2013 08:40 AM, Peter De Schrijver wrote:
> Many clocks are common between several Tegra SoCs. Define an enum to list
> them so we can move them to separate files which can be shared between
> SoCs. Each SoC specific file will provide an array with the common clocks
> which are present on the SoC and their DT binding ID.
So, this enum is purely something internal to the driver, and is in no
way related to the DT binding clock IDs, nor the HW peripheral clock
register bits, and finally is a union of all extant clocks across all chips?
If so, I suppose it's OK to make an enum for this. If not, the same
comments I had re: trying to unify the DT binding clock IDs would apply
here; if there's no architectural guarantee that the clock IDs will be
kept the same across all future chips, assuming they are the same seems
dangerous...
next prev parent reply other threads:[~2013-09-23 18:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 14:40 [PATCH 00/12] Introduce common infra for tegra clocks Peter De Schrijver
[not found] ` <1379515331-19427-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-18 14:40 ` [PATCH 01/12] clk: tegra: simplify periph clock data Peter De Schrijver
[not found] ` <1379515331-19427-2-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-23 17:29 ` Stephen Warren
2013-09-18 14:40 ` [PATCH 02/12] clk: tegra: periph_clk_enb_refcnt as common infra Peter De Schrijver
2013-09-18 14:40 ` [PATCH 04/12] clk: tegra: move some PLLC and PLLXC init to clk-pll.c Peter De Schrijver
2013-09-18 14:40 ` [PATCH 05/12] clk: tegra: add header for common tegra clock IDs Peter De Schrijver
2013-09-23 18:05 ` Stephen Warren [this message]
[not found] ` <524082E3.8070801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-09-24 8:08 ` Peter De Schrijver
2013-09-18 14:40 ` [PATCH 07/12] clk: tegra: move audio clk to common file Peter De Schrijver
2013-09-23 18:22 ` Stephen Warren
2013-09-18 14:41 ` [PATCH 08/12] clk: tegra: move periph clocks " Peter De Schrijver
[not found] ` <1379515331-19427-9-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-23 18:31 ` Stephen Warren
2013-09-24 8:20 ` Peter De Schrijver
[not found] ` <20130924082004.GJ30013-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-09-24 16:44 ` Stephen Warren
2013-09-18 14:41 ` [PATCH 09/12] clk: tegra: move PMC " Peter De Schrijver
2013-09-18 14:41 ` [PATCH 10/12] clk: tegra: move fixed " Peter De Schrijver
2013-09-23 18:34 ` Stephen Warren
[not found] ` <524089C8.4010108-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-09-24 8:32 ` Peter De Schrijver
[not found] ` <20130924083231.GK30013-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-09-24 16:47 ` Stephen Warren
2013-09-18 14:41 ` [PATCH 11/12] clk: tegra: introduce common tegra_osc_clk_init Peter De Schrijver
2013-09-18 14:41 ` [PATCH 12/12] clk: tegra: introduce common gen4 super clock Peter De Schrijver
2013-09-23 18:38 ` Stephen Warren
2013-09-18 14:48 ` [PATCH 00/12] Introduce common infra for tegra clocks Peter De Schrijver
2013-09-18 14:40 ` [PATCH 03/12] clk: tegra: Add TEGRA_PERIPH_NO_DIV flag Peter De Schrijver
[not found] ` <1379515331-19427-4-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-23 17:52 ` Stephen Warren
2013-09-18 14:40 ` [PATCH 06/12] clk: tegra: add common infra for DT clocks Peter De Schrijver
2013-09-23 18:16 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524082E3.8070801@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=pwalmsley@nvidia.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox