From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arto Merilainen Subject: Re: [PATCHv3 4/4] gpu: host1x: Add runtime pm support for host1x Date: Wed, 2 Oct 2013 08:40:53 +0300 Message-ID: <524BB1E5.9080601@nvidia.com> References: <1380024325-18280-1-git-send-email-amerilainen@nvidia.com> <1380024325-18280-5-git-send-email-amerilainen@nvidia.com> <524B11AA.30400@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <524B11AA.30400-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Terje Bergstrom , Thierry Reding , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Mayuresh Kulkarni List-Id: linux-tegra@vger.kernel.org On 10/01/2013 09:17 PM, Stephen Warren wrote: > On 09/24/2013 06:05 AM, Arto Merilainen wrote: >> From: Mayuresh Kulkarni >> >> This patch adds runtime pm support for host1x hardware unit. This >> allows host1x clock to be turned off when it is idle. If pm runtime >> is not configured, we enable host1x clock in device probe and disable >> it in remove. > >> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c > >> +static int host1x_runtime_suspend(struct device *dev); >> +static int host1x_runtime_resume(struct device *dev); > > You could avoid having these prototypes by simply putting the function > bodies earlier on in the file, somewhere before they're used. I don't > care much either way, but I've certainly seen some people care about > this and ask for them to be moved. Will fix. - Arto