Re: [PATCH v2 13/13] WIP: ARM: tegra: Add Tegra114 powergate support

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 10/15/2013 09:28 AM, Thierry Reding wrote:
> Extend the list of power gates found on Tegra114. Note that there are
> now holes in the list, so perhaps a simple array is no longer the best
> data structure to represent it. But perhaps this is good enough for now
> and can be cleaned up in a follow up patch?

Peter should probably comment on this, since I think he's touched the
powergate driver the most recently.

One idea might be to have the powergate IDs be "virtual", with a
virtual->HW ID mapping table per SoC. The virtual IDs need not have any
gaps. I'm not sure that having gaps is really much of a problem though,
except for the debugfs code in powergate.c...

> diff --git a/include/linux/tegra-powergate.h b/include/linux/tegra-powergate.h

> +#define TEGRA_POWERGATE_DISA	18
> +#define TEGRA_POWERGATE_DISB	19

s/DIS/DSI/ perhaps?

> -#define TEGRA_POWERGATE_CPU0	TEGRA_POWERGATE_CPU

I expect that was added deliberately. Perhaps Peter or Joseph can
comment? Admittedly, it's not used right now.

BTW, while you're fiddling with powergate.c, I note that
mach-tegra/pmc.c #defines some TEGRA_POWERGATE_xxx rather than including
tegra-powergate.h. Can you fix that?