From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: "khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org"
<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org"
<linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
"broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
<lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v5 0/3] Add power control for lm90
Date: Wed, 16 Oct 2013 11:20:03 +0800 [thread overview]
Message-ID: <525E05E3.4040708@nvidia.com> (raw)
In-Reply-To: <1381137940-22608-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Hi, Jean
Do you have any comments on this series, or will you take them ?
Thanks.
Wei.
On 10/07/2013 05:25 PM, Wei Ni wrote:
> The device lm90 can be controlled by the vcc rail.
> Add function to power on/off the vcc.
> I will update all .dts files referencing this driver to
> match the new requirement in my next series.
>
> This series is v5, previous version patches are:
> [v4]: http://www.spinics.net/lists/lm-sensors/msg39583.html
> [v3]: http://www.spinics.net/lists/lm-sensors/msg39503.html
> [v2]: http://www.spinics.net/lists/arm-kernel/msg265373.html
> [v1]: http://www.mail-archive.com/linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg12034.html
>
> Changes from v4:
> 1. set vcc-supply as required property.
>
> Changes from v3:
> 1. change to use devm_regulator_get, as per discussion in previous patches.
> 2. just return errors when get error from regulator_get(), Mark's new dummy
> regulator can cope with errors.
> 3. add vendor prefix for GMT
> 3. list manufacturer in the binding doc.
>
> Changes from v2:
> 1. use devm_regulator_get_optional(), as suggested by Mark.
> 2. remove the lm90_power_control(), enable the regulator in the probe()
> directly, so the codes are more clear, as suggested by Alexander and Guenter.
> 3. change the binding documentation, as per Stephen suggestion.
> 4. couple of changes, as per previous review.
>
> Changes from v1:
> 1. if get regulator failed, we should continue to run probe function,
> not return fail.
> 2. call regulator_put() in error handler and remove function.
> 3. add LM90 DT binding document.
>
> Wei Ni (3):
> hwmon: (lm90) Add power control
> of: add vendor prefix for GMT
> Documentation: dt: hwmon: add OF document for LM90
>
> Documentation/devicetree/bindings/hwmon/lm90.txt | 44 ++++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> drivers/hwmon/lm90.c | 19 +++++++++
> 3 files changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/lm90.txt
>
next prev parent reply other threads:[~2013-10-16 3:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 9:25 [PATCH v5 0/3] Add power control for lm90 Wei Ni
[not found] ` <1381137940-22608-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-07 9:25 ` [PATCH v5 1/3] hwmon: (lm90) Add power control Wei Ni
[not found] ` <1381137940-22608-2-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-14 12:38 ` Jean Delvare
2013-10-07 9:25 ` [PATCH v5 2/3] of: add vendor prefix for GMT Wei Ni
[not found] ` <1381137940-22608-3-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-12 14:39 ` Jean Delvare
[not found] ` <20131112153934.30543f8d-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-11-13 9:57 ` Wei Ni
2013-10-07 9:25 ` [PATCH v5 3/3] Documentation: dt: hwmon: add OF document for LM90 Wei Ni
[not found] ` <1381137940-22608-4-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-14 12:33 ` Jean Delvare
[not found] ` <20131114133320.00ad70c0-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-11-15 1:21 ` Wei Ni
[not found] ` <5285772E.2090700-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-15 7:20 ` Jean Delvare
2013-10-08 20:30 ` [PATCH v5 0/3] Add power control for lm90 Stephen Warren
2013-10-16 3:20 ` Wei Ni [this message]
[not found] ` <525E05E3.4040708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-18 1:45 ` Wei Ni
[not found] ` <526092A6.4050205-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-30 2:38 ` Wei Ni
[not found] ` <52707138.10903-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-30 14:55 ` Jean Delvare
[not found] ` <20131030155542.7a09b861-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-10-31 3:30 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E05E3.4040708@nvidia.com \
--to=wni-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox