Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

[Wei Ni]

On 10/16/2013 06:39 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
> 
> On Wed, Oct 16, 2013 at 12:36:46PM +0800, Wei Ni wrote:
>> On 10/12/2013 08:14 PM, Mark Brown wrote:
> 
>>> OK, I think the device tree board code just needs to set full
>>> constraints during machine initialisation.  We can't have multiple
> 
>> Hi, Mark, do you mean we can call regulator_has_full_constraints(), but
>> some platforms doesn't have board file now, they only have dts file, how
>> to call this functions?
> 
> There is still a board file for DT machines, it's just shared between
> all machines - it should be doing the call instead of the regulator
> framework trying to retrofit it.

So do you mean it should call the regulator_has_full_constraints() in
the .init_machine for all machines? If so, this will affect all boards,
for example, in arch/arm/mach-tegra, if we set full constraints in the
shared board file tegra.c, all tegra boards will be set, is it right?

Thanks.
Wei.

> 
> * Unknown Key
> * 0x7EA229BD
> 

Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

On Thu, Oct 17, 2013 at 12:39:55PM +0800, Wei Ni wrote:

> So do you mean it should call the regulator_has_full_constraints() in
> the .init_machine for all machines? If so, this will affect all boards,
> for example, in arch/arm/mach-tegra, if we set full constraints in the
> shared board file tegra.c, all tegra boards will be set, is it right?

Yes, but this is currently the case anyway for every system using DT -
all we'd be doing is moving this call earlier in init.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints

[Wei Ni]

On 10/17/2013 05:37 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
> 
> On Thu, Oct 17, 2013 at 12:39:55PM +0800, Wei Ni wrote:
> 
>> So do you mean it should call the regulator_has_full_constraints() in
>> the .init_machine for all machines? If so, this will affect all boards,
>> for example, in arch/arm/mach-tegra, if we set full constraints in the
>> shared board file tegra.c, all tegra boards will be set, is it right?
> 
> Yes, but this is currently the case anyway for every system using DT -
> all we'd be doing is moving this call earlier in init.

Ok, I will send out patches for Tegra series.

> 
> * Unknown Key
> * 0x7EA229BD
>