[PATCH v4 00/15] Introduce common infra for tegra clocks

[PATCH v4 00/15] Introduce common infra for tegra clocks

[Peter De Schrijver]

This patchset introduces common infrastructure for clocks which exist in
several Tegra SoCs. We also also move Tegra20, Tegra30 and Tegra114 to
this new infrastructure.

Changes since v1:
+ move common clks allocation to patch 2                                                                                                                       
+ adapt also Tegra20 and Tegra30 to the changes in patch 2                                                                                                     

Changes since v2:
+ move Tegra20 and Tegra30 to the common infrastructure
+ bug fixes and comments
+ merge clk-tegra-osc.c and clk-tegra-fixed.c in 1 file

Changes since v3:
+ aggregate all changes for Tegra20 and Tegra30 into 1 file per SoC
+ add CLK_SET_RATE_PARENT for NODIV clocks to fix some warnings on Tegra30
+ rename tegra_clk_periph_banks()

Peter De Schrijver (15):
  ARM: tegra30: add missing CLK IDs
  clk: tegra: simplify periph clock data
  clk: tegra: common periph_clk_enb_refcnt and clks
  clk: tegra: Add TEGRA_PERIPH_NO_DIV flag
  clk: tegra: move some PLLC and PLLXC init to clk-pll.c
  clk: tegra: move fields to tegra_clk_pll_params
  clk: tegra: add header for common tegra clock IDs
  clk: tegra: add common infra for DT clocks
  clk: tegra: add clkdev registration infra
  clk: tegra: move audio clk to common file
  clk: tegra: move periph clocks to common file
  clk: tegra: move PMC, fixed clocks to common files
  clk: tegra: introduce common gen4 super clock
  clk: tegra: move tegra30 to common infra
  clk: tegra: move tegra20 to common infra

 drivers/clk/tegra/Makefile               |    6 +-
 drivers/clk/tegra/clk-id.h               |  213 ++++
 drivers/clk/tegra/clk-periph-gate.c      |    8 +-
 drivers/clk/tegra/clk-periph.c           |   18 +-
 drivers/clk/tegra/clk-pll.c              |  233 +++--
 drivers/clk/tegra/clk-tegra-audio.c      |  213 ++++
 drivers/clk/tegra/clk-tegra-fixed.c      |  113 +++
 drivers/clk/tegra/clk-tegra-periph.c     |  590 ++++++++++++
 drivers/clk/tegra/clk-tegra-pmc.c        |  131 +++
 drivers/clk/tegra/clk-tegra-super-gen4.c |  151 +++
 drivers/clk/tegra/clk-tegra114.c         | 1540 +++++++-----------------------
 drivers/clk/tegra/clk-tegra20.c          |  809 ++++++----------
 drivers/clk/tegra/clk-tegra30.c          | 1492 +++++++++--------------------
 drivers/clk/tegra/clk.c                  |  156 +++
 drivers/clk/tegra/clk.h                  |   99 ++-
 include/dt-bindings/clock/tegra30-car.h  |   10 +-
 16 files changed, 2899 insertions(+), 2883 deletions(-)
 create mode 100644 drivers/clk/tegra/clk-id.h
 create mode 100644 drivers/clk/tegra/clk-tegra-audio.c
 create mode 100644 drivers/clk/tegra/clk-tegra-fixed.c
 create mode 100644 drivers/clk/tegra/clk-tegra-periph.c
 create mode 100644 drivers/clk/tegra/clk-tegra-pmc.c
 create mode 100644 drivers/clk/tegra/clk-tegra-super-gen4.c

-- 
1.7.7.rc0.72.g4b5ea.dirty

Re: [PATCH v4 00/15] Introduce common infra for tegra clocks

[Peter De Schrijver]

On Thu, Oct 17, 2013 at 02:41:13PM +0200, Peter De Schrijver wrote:
> This patchset introduces common infrastructure for clocks which exist in
> several Tegra SoCs. We also also move Tegra20, Tegra30 and Tegra114 to
> this new infrastructure.
> 
> Changes since v1:
> + move common clks allocation to patch 2                                                                                                                       
> + adapt also Tegra20 and Tegra30 to the changes in patch 2                                                                                                     
> 
> Changes since v2:
> + move Tegra20 and Tegra30 to the common infrastructure
> + bug fixes and comments
> + merge clk-tegra-osc.c and clk-tegra-fixed.c in 1 file
> 
> Changes since v3:
> + aggregate all changes for Tegra20 and Tegra30 into 1 file per SoC
> + add CLK_SET_RATE_PARENT for NODIV clocks to fix some warnings on Tegra30
> + rename tegra_clk_periph_banks()
> 
> Peter De Schrijver (15):
>   ARM: tegra30: add missing CLK IDs
>   clk: tegra: simplify periph clock data
>   clk: tegra: common periph_clk_enb_refcnt and clks
>   clk: tegra: Add TEGRA_PERIPH_NO_DIV flag
>   clk: tegra: move some PLLC and PLLXC init to clk-pll.c
>   clk: tegra: move fields to tegra_clk_pll_params
>   clk: tegra: add header for common tegra clock IDs
>   clk: tegra: add common infra for DT clocks
>   clk: tegra: add clkdev registration infra
>   clk: tegra: move audio clk to common file
>   clk: tegra: move periph clocks to common file
>   clk: tegra: move PMC, fixed clocks to common files
>   clk: tegra: introduce common gen4 super clock
>   clk: tegra: move tegra30 to common infra
>   clk: tegra: move tegra20 to common infra
> 

on top of git://nv-tegra.nvidia.com/user/pdeschrijver/linux.git tegra-clk-patches-1

Re: [PATCH v4 00/15] Introduce common infra for tegra clocks

[Stephen Warren]

On 10/17/2013 06:41 AM, Peter De Schrijver wrote:
> This patchset introduces common infrastructure for clocks which exist in
> several Tegra SoCs. We also also move Tegra20, Tegra30 and Tegra114 to
> this new infrastructure.

This series, and the other series "[PATCH v3 0/7] Tegra124 clock support",

Tested-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Patch 1 in this series also (or the whole lot if you want),
Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

There are some ifdef issues though, which should be fixed before
actually applying this:

tegra_defconfig builds fine.

tegra_defconfig minus CONFIG_ARCH_TEGRA_114_SOC yields:

> drivers/clk/tegra/clk-pll.c:1734:12: error: ‘clk_pll_iddq_enable’ undeclared here (not in a function)
> drivers/clk/tegra/clk-pll.c:1735:13: error: ‘clk_pll_iddq_disable’ undeclared here (not in a function)
> drivers/clk/tegra/clk-pll.c:1737:16: error: ‘clk_pll_ramp_round_rate’ undeclared here (not in a function)
> drivers/clk/tegra/clk-pll.c:1738:14: error: ‘clk_pllxc_set_rate’ undeclared here (not in a function)
> drivers/clk/tegra/clk-pll.c: In function ‘tegra_clk_register_pllss’:
> drivers/clk/tegra/clk-pll.c:1781:2: error: implicit declaration of function ‘_clip_vco_min’ [-Werror=implicit-function-declaration]
> drivers/clk/tegra/clk-pll.c:1785:2: error: implicit declaration of function ‘_pll_fixed_mdiv’ [-Werror=implicit-function-declaration]

(Thanks for Aaron Plattner for pointing that out)

Can you please double-check all 15 valid combinations of
CONFIG_ARCH_TEGRA_xx_SOC to make sure they all build.