Re: [PATCH v5 0/3] Add power control for lm90

[Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

On 10/16/2013 11:20 AM, Wei Ni wrote:
> Hi, Jean
> 
> Do you have any comments on this series, or will you take them ?

Hi, Jean, will you apply this series befor the 3.13 merge window?

Since I forgot to tell Stephen not to apply the "[PATCH 0/2] Update dts
file to support lm90 well" untile this series are accept, so if without
this change, the lm90 may be broken on the Dalmore board.

Thanks.
Wei.

> 
> Thanks.
> Wei.
> 
> On 10/07/2013 05:25 PM, Wei Ni wrote:
>> The device lm90 can be controlled by the vcc rail.
>> Add function to power on/off the vcc.
>> I will update all .dts files referencing this driver to
>> match the new requirement in my next series.
>>
>> This series is v5, previous version patches are:
>> [v4]: http://www.spinics.net/lists/lm-sensors/msg39583.html
>> [v3]: http://www.spinics.net/lists/lm-sensors/msg39503.html
>> [v2]: http://www.spinics.net/lists/arm-kernel/msg265373.html
>> [v1]: http://www.mail-archive.com/linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg12034.html
>>
>> Changes from v4:
>> 1. set vcc-supply as required property.
>>
>> Changes from v3:
>> 1. change to use devm_regulator_get, as per discussion in previous patches.
>> 2. just return errors when get error from regulator_get(), Mark's new dummy
>> regulator can cope with errors.
>> 3. add vendor prefix for GMT
>> 3. list manufacturer in the binding doc.
>>
>> Changes from v2:
>> 1. use devm_regulator_get_optional(), as suggested by Mark.
>> 2. remove the lm90_power_control(), enable the regulator in the probe()
>> directly, so the codes are more clear, as suggested by Alexander and Guenter.
>> 3. change the binding documentation, as per Stephen suggestion.
>> 4. couple of changes, as per previous review.
>>
>> Changes from v1:
>> 1. if get regulator failed, we should continue to run probe function,
>> not return fail.
>> 2. call regulator_put() in error handler and remove function.
>> 3. add LM90 DT binding document.
>>
>> Wei Ni (3):
>>   hwmon: (lm90) Add power control
>>   of: add vendor prefix for GMT
>>   Documentation: dt: hwmon: add OF document for LM90
>>
>>  Documentation/devicetree/bindings/hwmon/lm90.txt   |   44 ++++++++++++++++++++
>>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>>  drivers/hwmon/lm90.c                               |   19 +++++++++
>>  3 files changed, 64 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/hwmon/lm90.txt
>>
>