From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Terje_Bergstr=F6m?= Subject: Re: [PATCH -next] drm/tegra: add missing clk_disable_unprepare() on error in gr2d_probe() Date: Mon, 28 Oct 2013 10:33:38 +0200 Message-ID: <526E2162.5030106@nvidia.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wei Yongjun , "thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "airlied-cv59FeDIM0c@public.gmane.org" , "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org" , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" Cc: "yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 21.10.2013 08:38, Wei Yongjun wrote: > From: Wei Yongjun > > Add the missing clk_disable_unprepare() before return > from gr2d_probe() in the error handling case. > > Signed-off-by: Wei Yongjun > --- > drivers/gpu/drm/tegra/gr2d.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c > index 73b79ba..7f4eb11 100644 > --- a/drivers/gpu/drm/tegra/gr2d.c > +++ b/drivers/gpu/drm/tegra/gr2d.c > @@ -186,6 +186,7 @@ static int gr2d_probe(struct platform_device *pdev) > err = host1x_client_register(&gr2d->client.base); > if (err < 0) { > dev_err(dev, "failed to register host1x client: %d\n", err); > + clk_disable_unprepare(gr2d->clk); > return err; > } > > Looks good. Reviewed-by: Terje Bergstrom Terje