public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	"broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH RESEND] ARM: tegra: set regulator full constraints
Date: Fri, 1 Nov 2013 09:31:44 +0800	[thread overview]
Message-ID: <52730480.6020607@nvidia.com> (raw)
In-Reply-To: <52727DB7.9030109-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

On 10/31/2013 11:56 PM, Stephen Warren wrote:
> On 10/31/2013 01:05 AM, Wei Ni wrote:
>> Set full constraints during machine initialisation, so that the
>> regulator_get() can get the dummy regulator if the regulator is
>> physically present and enabled.
>> Discussed this in the link:
>> https://lkml.org/lkml/2013/10/8/40
> 
> Is this needed to fix some bug that'll be in 3.13 or earlier, or does it
> just solve a problem that will only be exposed in new code that will
> appear in 3.14 or later?

Let me explain this patch.
I discovered this problem when I worked on lm90 driver.
When I appiled my lm90 power control patches (this patch still in
review), I found the lm90 will be probed failed on Ventana board,
because on this board, the lm90 regulator is physically present and
enabled, so the lm90 driver can't use regulator_get() to get regulator,
and if we didn't set this full contraints, it can't get the dummy
regulator either, then probe failed.
So I think it's better to applied this patch earliy, because this solve
the compatible issue between Mark's dumy regulator patches, device
driver and DT.

Thanks.
Wei.

> 
> In other words, do I need to apply this for 3.13, or can I hold off
> until after the merge window?
> 
> It'd be helpful if the commit description described which
> driver/board/DT/commit/... was affected by this. That way, I'd know the
> answer to my question just by reading the commit description.
> 

  parent reply	other threads:[~2013-11-01  1:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31  7:05 [PATCH RESEND] ARM: tegra: set regulator full constraints Wei Ni
     [not found] ` <1383203126-3243-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-31 15:56   ` Stephen Warren
     [not found]     ` <52727DB7.9030109-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-01  1:31       ` Wei Ni [this message]
     [not found]         ` <52730480.6020607-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-01 16:01           ` Stephen Warren
2013-10-31 16:20   ` Mark Brown
     [not found]     ` <20131031162029.GF2493-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-04  5:59       ` Wei Ni
     [not found]         ` <527737C5.5080901-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-04 16:18           ` Mark Brown
     [not found]             ` <20131104161828.GK2493-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-05  9:05               ` Wei Ni
     [not found]                 ` <5278B4CB.9050305-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-06  8:51                   ` Mark Brown
     [not found]                     ` <20131106085100.GB11602-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-06 10:39                       ` Wei Ni
     [not found]                         ` <527A1C47.6050405-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-06 11:01                           ` Mark Brown
     [not found]                             ` <20131106110154.GG11602-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-12  5:52                               ` Wei Ni
     [not found]                                 ` <5281C228.3000404-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-12 18:20                                   ` Stephen Warren
     [not found]                                     ` <5282717C.3050502-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-13 10:12                                       ` Wei Ni
2013-11-13 12:23                                       ` Mark Brown
     [not found]                                         ` <20131113122329.GC878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-13 17:29                                           ` Stephen Warren
     [not found]                                             ` <5283B6E3.9070206-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-13 19:07                                               ` Mark Brown
     [not found]                                                 ` <20131113190745.GD878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-13 20:13                                                   ` Stephen Warren
     [not found]                                                     ` <5283DD52.5050903-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-13 20:49                                                       ` Mark Brown
     [not found]                                                         ` <20131113204923.GG878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-13 21:59                                                           ` Stephen Warren
     [not found]                                                             ` <5283F625.403-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-13 22:29                                                               ` Mark Brown
     [not found]                                                                 ` <20131113222953.GA26614-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-13 23:41                                                                   ` Stephen Warren
     [not found]                                                                     ` <52840E23.5080105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-14 11:36                                                                       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52730480.6020607@nvidia.com \
    --to=wni-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox