Re: [PATCH RESEND] ARM: tegra: set regulator full constraints

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 11/11/2013 10:52 PM, Wei Ni wrote:
> On 11/06/2013 07:01 PM, Mark Brown wrote:
>> * PGP Signed by an unknown key
>>
>> On Wed, Nov 06, 2013 at 06:39:03PM +0800, Wei Ni wrote:
>>
>>> I still can't find a good place to set full_constraints, could you
>>> please show me some reference codes where we can set it?
>>
>> The places where we unflatten the device tree for example, or start
>> instantiating devices from DT.
> 
> Hi, Mark
> Sorry, I really don't familiar with the DT, could you please take this
> by youself?

I think if you want a feature implemented or a patch created, it's up to
you to do so.

Isn't this as simple as moving the following code:

> 	/*
> 	 * Since DT doesn't provide an idiomatic mechanism for
> 	 * enabling full constraints and since it's much more natural
> 	 * with DT to provide them just assume that a DT enabled
> 	 * system has full constraints.
> 	 */
> 	if (of_have_populated_dt())
> 		has_full_constraints = true;

... out of regulator_init_complete() and into regulator_init()?

The only issue you may have to watch out for is: When is
regulator_init() called (i.e. when does core_initcall happen) relative
to when driver probe()s can be called? If it's earlier, then
core_initcall is early enough I suspect.