public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Mark Zhang <markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: Correct the length of AHB register space
Date: Tue, 12 Nov 2013 12:05:20 -0700	[thread overview]
Message-ID: <52827BF0.5070706@wwwdotorg.org> (raw)
In-Reply-To: <1383802327-11908-1-git-send-email-markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 11/06/2013 10:32 PM, Mark Zhang wrote:
> On Tegra114 it should be 0x12c.

> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi

>  	ahb: ahb {
>  		compatible = "nvidia,tegra114-ahb", "nvidia,tegra30-ahb";
> -		reg = <0x6000c004 0x14c>;
> +		reg = <0x6000c004 0x12c>;
>  	};

I don't think this is correct.

0x12c /is/ the address of the last defined register that exists.
However, the system memory map table in the TRM indicates that 336 bytes
of address space are allocated for this module, so the value should be
0x150 (minus 4 due to the base address offset of 4, so 0x14c) for all of
Tegra30/114/124. That matches what's already in DT.

For Tegra20, the TRM says that 268 bytes of address space are allocated
(which already takes account of the 4-byte base address offset) yielding
a size of 0x10c, which matches what's already in the DT.

  parent reply	other threads:[~2013-11-12 19:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07  5:32 [PATCH] ARM: tegra: Correct the length of AHB register space Mark Zhang
     [not found] ` <1383802327-11908-1-git-send-email-markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-12 19:05   ` Stephen Warren [this message]
     [not found]     ` <52827BF0.5070706-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-13  1:12       ` Mark Zhang
     [not found]         ` <5282D200.2090904-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-13  3:15           ` Stephen Warren
     [not found]             ` <5282EED2.3080603-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-11-13  5:14               ` Mark Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52827BF0.5070706@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox