From: Wei Ni <wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: "linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org"
<linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
"broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
"lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
<lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v5 3/3] Documentation: dt: hwmon: add OF document for LM90
Date: Fri, 15 Nov 2013 09:21:50 +0800 [thread overview]
Message-ID: <5285772E.2090700@nvidia.com> (raw)
In-Reply-To: <20131114133320.00ad70c0-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
On 11/14/2013 08:33 PM, Jean Delvare wrote:
> Hi Wei,
>
> On Mon, 7 Oct 2013 17:25:40 +0800, Wei Ni wrote:
>> Add OF document for LM90 in Documentation/devicetree/.
...
>> +
>> +Example LM90 node:
>> +
>> +temp-sensor {
>> + compatible = "onnn,nct1008";
>> + reg = <0x4c>;
>> + vcc-supply = <&palmas_ldo6_reg>;
>> + interrupt-parent = <&gpio>;
>> + interrupts = <TEGRA_GPIO(O, 4) IRQ_TYPE_LEVEL_LOW>;
>> +}
>
> Looks good to me, just one question: is it OK that interrupt-parent is
> not described in the document? Is it supposed to be a standard property?
As Stephen said in this series v3:
"I believe it's common not to document this, since it's implicitly
supported as part of any node that is an interrupt source."
This is a standard property.
>
> I'll add this file to the LM90 entry in MAINTAINERS, so that I can pick
> this patch in my tree.
Thanks again.
Wei.
>
next prev parent reply other threads:[~2013-11-15 1:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 9:25 [PATCH v5 0/3] Add power control for lm90 Wei Ni
[not found] ` <1381137940-22608-1-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-07 9:25 ` [PATCH v5 1/3] hwmon: (lm90) Add power control Wei Ni
[not found] ` <1381137940-22608-2-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-14 12:38 ` Jean Delvare
2013-10-07 9:25 ` [PATCH v5 2/3] of: add vendor prefix for GMT Wei Ni
[not found] ` <1381137940-22608-3-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-12 14:39 ` Jean Delvare
[not found] ` <20131112153934.30543f8d-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-11-13 9:57 ` Wei Ni
2013-10-07 9:25 ` [PATCH v5 3/3] Documentation: dt: hwmon: add OF document for LM90 Wei Ni
[not found] ` <1381137940-22608-4-git-send-email-wni-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-14 12:33 ` Jean Delvare
[not found] ` <20131114133320.00ad70c0-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-11-15 1:21 ` Wei Ni [this message]
[not found] ` <5285772E.2090700-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-11-15 7:20 ` Jean Delvare
2013-10-08 20:30 ` [PATCH v5 0/3] Add power control for lm90 Stephen Warren
2013-10-16 3:20 ` Wei Ni
[not found] ` <525E05E3.4040708-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-18 1:45 ` Wei Ni
[not found] ` <526092A6.4050205-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-30 2:38 ` Wei Ni
[not found] ` <52707138.10903-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-10-30 14:55 ` Jean Delvare
[not found] ` <20131030155542.7a09b861-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-10-31 3:30 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5285772E.2090700@nvidia.com \
--to=wni-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox