From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: [PATCH v5 3/3] Documentation: dt: hwmon: add OF document for LM90 Date: Fri, 15 Nov 2013 09:21:50 +0800 Message-ID: <5285772E.2090700@nvidia.com> References: <1381137940-22608-1-git-send-email-wni@nvidia.com> <1381137940-22608-4-git-send-email-wni@nvidia.com> <20131114133320.00ad70c0@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131114133320.00ad70c0-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare Cc: "linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org" , "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org" , "lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 11/14/2013 08:33 PM, Jean Delvare wrote: > Hi Wei, > > On Mon, 7 Oct 2013 17:25:40 +0800, Wei Ni wrote: >> Add OF document for LM90 in Documentation/devicetree/. ... >> + >> +Example LM90 node: >> + >> +temp-sensor { >> + compatible = "onnn,nct1008"; >> + reg = <0x4c>; >> + vcc-supply = <&palmas_ldo6_reg>; >> + interrupt-parent = <&gpio>; >> + interrupts = ; >> +} > > Looks good to me, just one question: is it OK that interrupt-parent is > not described in the document? Is it supposed to be a standard property? As Stephen said in this series v3: "I believe it's common not to document this, since it's implicitly supported as part of any node that is an interrupt source." This is a standard property. > > I'll add this file to the LM90 entry in MAINTAINERS, so that I can pick > this patch in my tree. Thanks again. Wei. >