From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi
Date: Fri, 6 Dec 2013 11:35:24 +0530 [thread overview]
Message-ID: <52A16924.6040902@nvidia.com> (raw)
In-Reply-To: <52A10A13.2020608@wwwdotorg.org>
On Friday 06 December 2013 04:49 AM, Stephen Warren wrote:
> On 12/05/2013 04:16 PM, Stephen Warren wrote:
>> On 12/05/2013 03:57 AM, Laxman Dewangan wrote:
>>> The tegra124 pinmux controller is identical to tegra114 with
>>> removing some of existing pins from T114 and adding new pins.
>> I already sent this patch.
> Oh, I do notice one difference between the two patches:
>
> Mine:
>
>> + reg = <0x70000868 0x148>, /* Pad control registers */
>> + <0x70003000 0x40c>; /* Mux registers */
> Yours:
>
>> + reg = <0x70000868 0x164 /* Pad control registers */
>> + 0x70003000 0x434>; /* PinMux registers */
> Are the increase register lengths in your patch correct? If so, I guess
> I'll drop my patch and replace it with yours if you fix up the unit address.
Yes, the last entry of the bank 0 and 1 are:
DRV_PINGROUP(ao4, 0x9c8, 2, 3, 4, 12, 7, 20, 7, 28, 2, 30,
2, Y),
and
PINGROUP(dp_hpd_pff0, DP, RSVD2, RSVD3,
RSVD4, DP, 0x3430, N, N, N),
next prev parent reply other threads:[~2013-12-06 6:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 10:57 [PATCH 0/4] pinctrl: tegra: Add pincontrol driver for Tegra124 SoC Laxman Dewangan
[not found] ` <1386241070-4350-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 10:57 ` [PATCH 1/4] pinctrl: tegra: Add devicetree binding document for Tegra124 Laxman Dewangan
[not found] ` <1386241070-4350-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 23:17 ` Stephen Warren
2013-12-06 6:21 ` Laxman Dewangan
2013-12-05 10:57 ` [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi Laxman Dewangan
2013-12-05 23:16 ` Stephen Warren
2013-12-05 23:19 ` Stephen Warren
2013-12-06 6:05 ` Laxman Dewangan [this message]
2013-12-05 10:57 ` [PATCH 3/4] ARM: tegra: select PINCTRL_TEGRA124 for Tegra124 SoC Laxman Dewangan
[not found] ` <1386241070-4350-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 23:17 ` Stephen Warren
2013-12-12 18:36 ` Stephen Warren
2013-12-05 10:57 ` [PATCH 4/4] pinctrl: tegra: add pinmux controller driver for Tegra124 Laxman Dewangan
[not found] ` <1386241070-4350-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-05 23:30 ` Stephen Warren
[not found] ` <52A10C7B.8070406-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-06 6:27 ` Laxman Dewangan
2013-12-06 17:08 ` Stephen Warren
2013-12-06 11:53 ` [PATCH 1/2] pinctrl: tegra: Various Tegra124 fixes Thierry Reding
[not found] ` <1386330839-30559-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-06 11:53 ` [PATCH 2/2] pinctrl: tegra: Whitespace fixes for Tegra124 Thierry Reding
[not found] ` <1386330839-30559-2-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-11 12:34 ` Linus Walleij
[not found] ` <CACRpkdYKqDgRkuQ4j6AeD+YWkh8r1hPCgjy1k90vQ2w+4vPxxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-12-11 12:33 ` Laxman Dewangan
2013-12-06 17:10 ` [PATCH 1/2] pinctrl: tegra: Various Tegra124 fixes Stephen Warren
[not found] ` <52A204E9.4080801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-06 19:33 ` Thierry Reding
2013-12-11 12:36 ` Linus Walleij
2013-12-06 9:58 ` [PATCH 4/4] pinctrl: tegra: add pinmux controller driver for Tegra124 Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A16924.6040902@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).