From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v5 1/3] mfd: tps6586x: add version detection Date: Fri, 06 Dec 2013 13:31:54 -0700 Message-ID: <52A2343A.2090008@wwwdotorg.org> References: <7812fb79beac0a6a409090f43d129893f9f93b5b.1386333697.git.stefan@agner.ch> <52A20E09.7090005@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: kai.poggensee-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org, Liam Girdwood , thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Stefan Agner , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 12/06/2013 01:24 PM, Lee Jones wrote: > > On 6 Dec 2013 17:49, "Stephen Warren" > wrote: >> >> On 12/06/2013 05:51 AM, Stefan Agner wrote: >> > Use the VERSIONCRC to determine the exact device version. According to >> > the datasheet this register can be used as device identifier. The >> > identification is needed since some tps6586x regulators use a different >> > voltage table. >> >> FWIW, this version looks good to me now. > > If that's an Ack I can apply it. Yes, it is. I thought you said you'd already applied it though, so I didn't write the ack, but if not: Acked-by: Stephen Warren