From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH -next] ASoC: tegra20-ac97: fix error return code in tegra20_ac97_platform_probe() Date: Mon, 16 Dec 2013 10:10:12 -0700 Message-ID: <52AF33F4.1060203@wwwdotorg.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wei Yongjun , lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, tiwai-l3A5Bk7waGM@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 12/13/2013 10:15 PM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return -ENODEV instead of 0 when no GPIO supplied in > tegra20_ac97_platform_probe(). > diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c > @@ -358,6 +358,7 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev) > } > } else { > dev_err(&pdev->dev, "no codec-reset GPIO supplied\n"); > + ret = -ENODEV; This would be better as: ret = ac97->reset_gpio; Since that will propagate the exact error code (and incidentally, deferred probe will work correctly then). > if (!gpio_is_valid(ac97->sync_gpio)) { > dev_err(&pdev->dev, "no codec-sync GPIO supplied\n"); > + ret = -ENODEV; Similarly here, ret = ac97->sync_gpio;