From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Stefan Agner
<stefan.agner-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>,
stefan-XLVq0VzYD2Y@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org
Subject: Re: [cbootimage-configs PATCH] Add Colibri T30 BCT files
Date: Mon, 16 Dec 2013 11:22:16 -0700 [thread overview]
Message-ID: <52AF44D8.8030306@wwwdotorg.org> (raw)
In-Reply-To: <1387217034-16426-1-git-send-email-stefan.agner-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
On 12/16/2013 11:03 AM, Stefan Agner wrote:
> The file defines memory timing for 1GB Nanya module for 400MHz used
> during boot.
> 2 files changed, 268 insertions(+)
> create mode 100755 tegra30/toradex/colibri-t30/Colibri_t30_12MHz_1GB_NT5CC256M16CP-DI_400MHz-shmoo.bct.cfg
> create mode 100644 tegra30/toradex/colibri-t30/Colibri_t30_12MHz_1GB_NT5CC256M16CP-DI_400MHz-shmoo.img.cfg
I think you forgot build.sh and Makefile.
> diff --git a/tegra30/toradex/colibri-t30/Colibri_t30_12MHz_1GB_NT5CC256M16CP-DI_400MHz-shmoo.bct.cfg b/tegra30/toradex/colibri-t30/Colibri_t30_12MHz_1GB_NT5CC256M16CP-DI_400MHz-shmoo.bct.cfg
> +# 3. This notice may not be removed or altered from any source distribution.
> +
> +
> +Version = 0x00030001;
...
> +DeviceParam[0].SdmmcParams.SdController = NvBootSdmmcCntrl_4;
> +
> +
> +DevType[1] = Sdmmc;
I'd rather all the double/triple blank lines be collapsed to just one
blank line.
prev parent reply other threads:[~2013-12-16 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 18:03 [cbootimage-configs PATCH] Add Colibri T30 BCT files Stefan Agner
[not found] ` <1387217034-16426-1-git-send-email-stefan.agner-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
2013-12-16 18:22 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF44D8.8030306@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
--cc=stefan.agner-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).