From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/2] ARM: tegra: fix missing pincontrol configuration for Venice2 Date: Wed, 18 Dec 2013 13:56:45 -0700 Message-ID: <52B20C0D.9030200@wwwdotorg.org> References: <1387371179-16725-1-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1387371179-16725-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan , thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 12/18/2013 05:52 AM, Laxman Dewangan wrote: > Compare the initial population of default pinmux configuration of Venice2 > with the chrome branch and add/fix the missing configurations. Wow, that's a big chunk of changes. Are you sure this is correct? Why was the original patch (which added the pinctrl nodes) so incorrect? Thierry, I thought you had mentioned comparing the pinctrl setup in linux-next with the downstream kernel for Venice2 and only found a difference in the PWM settings, which you sent a patch for. However, this patch is much larger than that. Where's the disconnect?