From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 10/10] ARM: tegra: Enable USB on Venice2
Date: Thu, 19 Dec 2013 14:37:36 -0700 [thread overview]
Message-ID: <52B36720.8080205@wwwdotorg.org> (raw)
In-Reply-To: <1387469182-14398-11-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 12/19/2013 09:06 AM, Thierry Reding wrote:
> USB1 and USB3 are routed to two external connectors, while USB2 is used
> for the integrated webcam.
>
> Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Note: connecting a USB mouse to USB3 works properly and lsusb also detects
> the integrated webcam, though I haven't tested whether the camera actually
> works.
>
> USB1 doesn't seem to work, but I suspect that might just be because it's
> used for recovery mode and we can't switch it around at runtime yet.
The two regulators you added don't actually hook up to any GPIOs for
control of VBUS, so perhaps this isn't surprising. The regulators added
for VBUS control by Laxman's patch (which I already applied) *do* have
some gpio properties. However, testing indicates:
* With Laxman's patch applied, and your patch 1/10 not applied since
it's a duplicate, this patch doesn't work, i.e. I see no USB devices.
* With Laxman's patch reverted and your patch 1/10 replacing it, I do
see USB devices, and they work. However, then we're not actually
controlling VBUS, so USB1 doesn't work.
Can you please rebase this whole series on the latest Tegra for-3.14/dt
and sort out the issues? Thanks.
next prev parent reply other threads:[~2013-12-19 21:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 16:06 [PATCH 00/10] ARM: tegra: Enable a bunch of functionality on Venice2 Thierry Reding
[not found] ` <1387469182-14398-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-19 16:06 ` [PATCH 01/10] ARM: tegra: Add AS3722 PMIC " Thierry Reding
[not found] ` <1387469182-14398-2-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-19 20:24 ` Stephen Warren
[not found] ` <52B355EC.9040306-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-20 6:53 ` Laxman Dewangan
[not found] ` <52B3E968.8090906-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-20 10:25 ` Thierry Reding
[not found] ` <20131220102542.GJ27787-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-12-20 10:46 ` Laxman Dewangan
[not found] ` <52B41FEA.7020608-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-20 16:57 ` Stephen Warren
[not found] ` <52B476EA.2040401-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-20 17:25 ` Laxman Dewangan
2013-12-19 21:47 ` Stephen Warren
[not found] ` <52B3695D.70601-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-20 11:14 ` Thierry Reding
[not found] ` <20131220111442.GK27787-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-12-20 17:02 ` Stephen Warren
2013-12-19 16:06 ` [PATCH 02/10] ARM: tegra: Hook up SDMMC3 power-supply " Thierry Reding
2013-12-19 16:06 ` [PATCH 03/10] ARM: tegra: Add Tegra124 host1x support Thierry Reding
2013-12-19 16:06 ` [PATCH 04/10] ARM: tegra: Add Tegra124 eDP support Thierry Reding
[not found] ` <1387469182-14398-5-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-19 20:46 ` Stephen Warren
[not found] ` <52B35B15.4090008-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-20 11:17 ` Thierry Reding
2013-12-19 16:06 ` [PATCH 05/10] ARM: tegra: Enable eDP for Venice2 Thierry Reding
[not found] ` <1387469182-14398-6-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-19 21:40 ` Stephen Warren
[not found] ` <52B367C7.9010301-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-20 10:20 ` Thierry Reding
[not found] ` <20131220102024.GI27787-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-12-20 17:01 ` Stephen Warren
2013-12-19 16:06 ` [PATCH 06/10] ARM: tegra: Add SPI controller nodes for Tegra124 Thierry Reding
[not found] ` <1387469182-14398-7-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-19 20:38 ` Stephen Warren
[not found] ` <52B35944.8090307-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-20 11:15 ` Thierry Reding
2013-12-19 16:06 ` [PATCH 07/10] ARM: tegra: Enable Venice2 keyboard Thierry Reding
[not found] ` <1387469182-14398-8-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-20 17:56 ` Stephen Warren
2013-12-19 16:06 ` [PATCH 08/10] ARM: tegra: Enable power key on Venice2 Thierry Reding
2013-12-19 16:06 ` [PATCH 09/10] ARM: tegra: Add Tegra124 USB support Thierry Reding
2013-12-19 16:06 ` [PATCH 10/10] ARM: tegra: Enable USB on Venice2 Thierry Reding
[not found] ` <1387469182-14398-11-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-12-19 21:37 ` Stephen Warren [this message]
[not found] ` <52B36720.8080205-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-12-20 2:59 ` Jim Lin
2013-12-20 11:53 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B36720.8080205@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).