Re: Unhandled LM90 irq 308 on Dalmore?

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 01/06/2014 12:40 PM, Guenter Roeck wrote:
> On Mon, Jan 06, 2014 at 12:13:12PM -0700, Stephen Warren wrote:
>> On 12/20/2013 10:47 PM, Paul Walmsley wrote:
>>>
>>> On 12/20/2013 08:26 AM, Stephen Warren wrote:
>> ...
>>>> Note that upstream Linux *only* supports Dalmore A04, and no other
>>>> version. If you have a different board revision, it's not expected to
>>>> work with upstream. IIRC, Eric Brower volunteered to track down the
>>>> correct board revision for people working on upstream.
>>>
>>> Indeed, that's probably the problem, then
>>>
>>> It would be good if this was documented somewhere in the upstream kernel
>>> tree.
>>
>> I'll send a patch to document that in the DTS file.
>>
>>> And even better if the kernel was able to read the Dalmore EEPROM
>>> and print out a warning upon kernel boot...
>>
>> That would be painful, since it'd be board-specific code that isn't
>> really coupled with a specific piece of HW for which there's a driver.
>> I'd rather avoid that kind of thing.
>>
> Another option might be for someone to add support for other board revisions,
> and create appropriate dts files.

We specifically decided not to support other board revisions to reduce
the support load.

> On a side note, if the board revisions are incompatible to each other,
> shouldn't the 'compatible' property be different ? Just wondering ...

Yes, if we did end up supporting other board revisions, we'd use
different compatible properties to differentiate them.