Re: [PATCH v2 0/2] Support to tune governor in run time

[Eduardo Valentin <eduardo.valentin@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1706 bytes --]

On 13-01-2014 15:01, Matthew Longnecker wrote:
> On 1/13/2014 7:42 AM, Eduardo Valentin wrote:
>>> This serie can support to turn governor for thermal zone in
>>> run time.
>>
>> Can you please explain why this is needed? Are you facing troubles with
>> current way to switch governors? If yes, can you please report them?

Looks like there is a need to switch governors from within kernel code,
but not explanation of use cases is provided.

>>
> 
> ....
> 
>>> Adds thermal_update_governor() function, so the thermal platform
>>> driver can use it to update governor.
>>
>> Here I cannot see why the platform driver would need to update a
>> governor, instead of a zone. Platform drivers are not supposed to be
>> aware of governors. For updating a zone we already have an API for that,
>> please check documentation.
>>
> 
> I think we have a miscommunication. The purpose of
> thermal_update_governor is to *switch* governors at runtime (from within
> the kernel).
> 
> Wei has used the term "update" in the sense of switch rather than
> "update" in the sense used by thermal_zone_device_update.

Fine, but why do you need it?

> 
> Eduardo, what is your recommended technique for setting the governor of
> a thermal zone device created via device tree?

So far the recommended (and existing) way is by user(land) decision.

> 
> thanks,
> Matt
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]