From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH v2 0/2] Support to tune governor in run time Date: Wed, 15 Jan 2014 10:06:26 -0400 Message-ID: <52D695E2.7080503@ti.com> References: <1389611863-7812-1-git-send-email-wni@nvidia.com> <52D4095C.205@ti.com> <52D43810.6030801@nvidia.com> <52D45BB7.1090002@ti.com> <52D4BA76.4040003@nvidia.com> <52D57762.8070609@ti.com> <52D67296.7050107@nvidia.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="x9XmOX0merNPE4UnA9KFcF0EHJOOFBAkH" Return-path: In-Reply-To: <52D67296.7050107-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wei Ni Cc: Eduardo Valentin , Matthew Longnecker , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org --x9XmOX0merNPE4UnA9KFcF0EHJOOFBAkH Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 15-01-2014 07:35, Wei Ni wrote: > On 01/15/2014 01:44 AM, Eduardo Valentin wrote: >> * PGP Signed by an unknown key >> >> Hello Wei, >> >> On 14-01-2014 00:17, Wei Ni wrote: >>> On 01/14/2014 05:33 AM, Eduardo Valentin wrote: >>>>> Old Signed by an unknown key >>>> >>>> On 13-01-2014 15:01, Matthew Longnecker wrote: >>>>> On 1/13/2014 7:42 AM, Eduardo Valentin wrote: >>>>>>> This serie can support to turn governor for thermal zone in >>>>>>> run time. >>>>>> >>>>>> Can you please explain why this is needed? Are you facing troubles= with >>>>>> current way to switch governors? If yes, can you please report the= m? >>>> >>>> Looks like there is a need to switch governors from within kernel co= de, >>>> but not explanation of use cases is provided. >>> >>> In fact, with the of-thermal framework, the driver can't initialize t= o >>> any governor, even default governor, it may be a bug. As we discussed= in >> >> I see. Using default governor is not a bug. The thermal zone shall not= >> be defined in way that it is specific to a policy. We must remember th= at >> DT is not used for specifying policies, but only describing hardware. >> >>> other mail list, we should not set governor in DT, and I think the >>> platform driver should be able to set to any governors which it want,= so >> >> OK. But still, because you believe the platform driver has to set the >> governor, this is not a bug. Defining which policy is used to control = a >> zone can be a later decision in the boot process. Specially because th= e >> critical requirements are not dealt by the governors anyway. >> >>> I this patch, the driver can call the thermal_update_governor() to >>> switch to new governor in kernel space. >> >> I see. >> >>> For example, there have two thermal driver, using of-thermal to regis= ter >>> thermal zone device. One want to set to step_wise governor, another w= ant >>> fair_share, how can we do? I think after they calling the >>> thermal_zone_of_sensor_register(), they can call the >>> thermal_update_governor() to set the governor which they want. >> >> OK. Now I get a better view of what you are trying to achieve with thi= s >> series. However, why can't you hand this decision off to userland, >> during, say very early boot sequence? >=20 > I think the thermal_zone_device_register() provide a way to set governo= r > when register a thermal zone, and this function is exposed to all > driver, so I supposed the thermal framework can support to handle the > governor in kernel. In fact, we lost that link if going via DT definitions. I will consider your point. On the other hand, the thermal framework does not allow for platform drivers to switch governors after registration, only via user request. >=20 > Anyway, let's consider to switch the governor in user space. OK. >=20 >> >> >>> >>>> >>>>>> >>>>> >>>>> .... >>>>> >>>>>>> Adds thermal_update_governor() function, so the thermal platform >>>>>>> driver can use it to update governor. >>>>>> >>>>>> Here I cannot see why the platform driver would need to update a >>>>>> governor, instead of a zone. Platform drivers are not supposed to = be >>>>>> aware of governors. For updating a zone we already have an API for= that, >>>>>> please check documentation. >>>>>> >>>>> >>>>> I think we have a miscommunication. The purpose of >>>>> thermal_update_governor is to *switch* governors at runtime (from w= ithin >>>>> the kernel). >>>>> >>>>> Wei has used the term "update" in the sense of switch rather than >>>>> "update" in the sense used by thermal_zone_device_update. >>>> >>>> Fine, but why do you need it? >>> >>> Yes, I have consider to use "switch", but As my commit in the patch, = in >>> the future, the governor may be more complex, it may need governor >>> parameter/configuration, and need to be tuned in run-time or in >>> initialization. >>> In fact we develop a new governor, based on PID logic. It will need s= ome >>> parameters, such as proportional, integral and derivative. these valu= e >>> will be initialized in different values for different thermal zone, s= o >>> we want to use the thermal_zone_device_update() to switch governor or= >>> update the governor's parameters for different thermal zone. >>> >>>> >>>>> >>>>> Eduardo, what is your recommended technique for setting the governo= r of >>>>> a thermal zone device created via device tree? >>>> >>>> So far the recommended (and existing) way is by user(land) decision.= >>>> >>>>> >>>>> thanks, >>>>> Matt >>>>> >>>>> --=20 >>>>> To unsubscribe from this list: send the line "unsubscribe linux-pm"= in >>>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>>> >>>>> >>>> >>>> >>> >>> >>> >> >> >=20 >=20 >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --x9XmOX0merNPE4UnA9KFcF0EHJOOFBAkH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlLWleIACgkQCXcVR3XQvP2NFwEAqKkk1n84BT33CAnM0VDm2MX5 YCPRIiK30GntMf8C0JkBAOdDSiiL7wNMOu67T0BpZd5w4PuiivhkNWnnp7MKKa5L =5Ln1 -----END PGP SIGNATURE----- --x9XmOX0merNPE4UnA9KFcF0EHJOOFBAkH--