From: Stephen Warren <swarren@wwwdotorg.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-tegra@vger.kernel.org,
olof@lixom.net, Stephen Warren <swarren@nvidia.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: enable UART_BUG_NOMSR for Tegra
Date: Wed, 15 Jan 2014 10:30:05 -0700 [thread overview]
Message-ID: <52D6C59D.4070402@wwwdotorg.org> (raw)
In-Reply-To: <20140115111205.GA11732@xps8300>
On 01/15/2014 04:12 AM, Heikki Krogerus wrote:
> Hi,
>
> On Tue, Jan 07, 2014 at 03:00:12PM -0700, Stephen Warren wrote:
>> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
>> index e33d38cb170f..61ecd709a722 100644
>> --- a/drivers/tty/serial/8250/8250_core.c
>> +++ b/drivers/tty/serial/8250/8250_core.c
>> @@ -2670,6 +2670,10 @@ static void serial8250_config_port(struct uart_port *port, int flags)
>> if (port->type == PORT_16550A && port->iotype == UPIO_AU)
>> up->bugs |= UART_BUG_NOMSR;
>>
>> + /* HW bugs may trigger IRQ while IIR == NO_INT */
>> + if (port->type == PORT_TEGRA)
>> + up->bugs |= UART_BUG_NOMSR;
>> +
>
> Is there any reason this needs to be in 8250_core.c? Why not set it in
> drivers/tty/serial/of_serial.c?
I imagine the code could go in either place.
I don't see any advantage moving it to of_serial.c, and it'd actively be
a disadvantage as far as I'm concerned; PORT_TEGRA is defined in 8250.c,
and other code which enable the same UART_BUG_NOMSR flag is in exactly
the same place, which keeps similar code co-located.
next prev parent reply other threads:[~2014-01-15 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 22:00 [PATCH] serial: 8250: enable UART_BUG_NOMSR for Tegra Stephen Warren
2014-01-15 11:12 ` Heikki Krogerus
2014-01-15 17:30 ` Stephen Warren [this message]
2014-01-16 8:52 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D6C59D.4070402@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-serial@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=stable@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox