From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Alexandre Courbot
<acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 5/5] ARM: tegra: cpuidle: use firmware call for power down
Date: Wed, 22 Jan 2014 13:45:00 -0700 [thread overview]
Message-ID: <52E02DCC.1000404@wwwdotorg.org> (raw)
In-Reply-To: <1390299016-14105-6-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 01/21/2014 03:10 AM, Alexandre Courbot wrote:
> Invoke the do_idle() firmware call before suspending a CPU so that the
> underlying firmware (if any) can take necessary action.
> diff --git a/arch/arm/mach-tegra/cpuidle-tegra114.c b/arch/arm/mach-tegra/cpuidle-tegra114.c
> @@ -45,6 +46,8 @@ static int tegra114_idle_power_down(struct cpuidle_device *dev,
>
> clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu);
>
> + call_firmware_op(do_idle);
> +
> cpu_suspend(0, tegra30_sleep_cpu_secondary_finish);
>
> clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu);
Don't you need to have the kernel also *not* do something when entering
idle; doesn't the FW op replace some of the register writes that the
kernel would otherwise be doing?
next prev parent reply other threads:[~2014-01-22 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 10:10 [PATCH 0/5] ARM: firmware: improvements to Trusted Foundations support Alexandre Courbot
2014-01-21 10:10 ` [PATCH 1/5] ARM: trusted_foundations: fix vendor prefix typos Alexandre Courbot
2014-01-21 10:10 ` [PATCH 2/5] ARM: trusted_foundations: fallback when TF support is missing Alexandre Courbot
2014-01-21 10:10 ` [PATCH 4/5] ARM: trusted_foundations: implement do_idle() Alexandre Courbot
[not found] ` <1390299016-14105-5-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-22 20:43 ` Stephen Warren
[not found] ` <52E02D8C.7090309-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-01-23 7:39 ` Alexandre Courbot
2014-01-21 10:10 ` [PATCH 5/5] ARM: tegra: cpuidle: use firmware call for power down Alexandre Courbot
[not found] ` <1390299016-14105-6-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-22 20:45 ` Stephen Warren [this message]
2014-01-23 7:39 ` Alexandre Courbot
[not found] ` <CAAVeFuKLtC62+bujY4724hMV_6M8Ow0s=6zRn_M87VX4PHQgxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-05 16:28 ` Stephen Warren
2014-02-06 2:28 ` Alexandre Courbot
[not found] ` <1390299016-14105-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-21 10:10 ` [PATCH 3/5] ARM: firmware: enable Trusted Foundations by default Alexandre Courbot
[not found] ` <1390299016-14105-4-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-01-22 20:42 ` Stephen Warren
2014-01-23 7:38 ` Alexandre Courbot
2014-01-22 20:47 ` [PATCH 0/5] ARM: firmware: improvements to Trusted Foundations support Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E02DCC.1000404@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).