* [PATCH 2/7] drivers/amba: don't check resource with devm_ioremap_resource [not found] ` <1389700739-3696-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> @ 2014-01-14 11:58 ` Wolfram Sang [not found] ` <1389700739-3696-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Wolfram Sang @ 2014-01-14 11:58 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: Wolfram Sang, Russell King, Stephen Warren, Thierry Reding, linux-tegra-u79uwXL29TY76Z2rM5mHXA devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> --- Should go via subsystem tree drivers/amba/tegra-ahb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/amba/tegra-ahb.c b/drivers/amba/tegra-ahb.c index 1f44e56c..558a239 100644 --- a/drivers/amba/tegra-ahb.c +++ b/drivers/amba/tegra-ahb.c @@ -256,8 +256,6 @@ static int tegra_ahb_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; ahb->regs = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(ahb->regs)) return PTR_ERR(ahb->regs); -- 1.8.5.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <1389700739-3696-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]
* Re: [PATCH 2/7] drivers/amba: don't check resource with devm_ioremap_resource [not found] ` <1389700739-3696-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> @ 2014-01-14 13:32 ` Thierry Reding 2014-01-14 17:40 ` Stephen Warren 2014-02-05 17:18 ` Stephen Warren 2 siblings, 0 replies; 7+ messages in thread From: Thierry Reding @ 2014-01-14 13:32 UTC (permalink / raw) To: Wolfram Sang Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Russell King, Stephen Warren, linux-tegra-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 454 bytes --] On Tue, Jan 14, 2014 at 12:58:53PM +0100, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> > --- > > Should go via subsystem tree > > drivers/amba/tegra-ahb.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/7] drivers/amba: don't check resource with devm_ioremap_resource [not found] ` <1389700739-3696-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2014-01-14 13:32 ` Thierry Reding @ 2014-01-14 17:40 ` Stephen Warren [not found] ` <52D57688.8070105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> 2014-02-05 17:18 ` Stephen Warren 2 siblings, 1 reply; 7+ messages in thread From: Stephen Warren @ 2014-01-14 17:40 UTC (permalink / raw) To: Wolfram Sang, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: Russell King, Thierry Reding, linux-tegra-u79uwXL29TY76Z2rM5mHXA On 01/14/2014 04:58 AM, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. This looks fine. I expect to apply it for 3.15 after the 3.14 merge window, unless it's urgent to get it into 3.14 for some reason? ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <52D57688.8070105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]
* Re: [PATCH 2/7] drivers/amba: don't check resource with devm_ioremap_resource [not found] ` <52D57688.8070105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> @ 2014-01-14 18:30 ` Wolfram Sang 0 siblings, 0 replies; 7+ messages in thread From: Wolfram Sang @ 2014-01-14 18:30 UTC (permalink / raw) To: Stephen Warren Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Russell King, Thierry Reding, linux-tegra-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 209 bytes --] > This looks fine. I expect to apply it for 3.15 after the 3.14 merge > window, unless it's urgent to get it into 3.14 for some reason? Nope, it is not. I wasn't aiming for 3.14, it was simply in my queue. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/7] drivers/amba: don't check resource with devm_ioremap_resource [not found] ` <1389700739-3696-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 2014-01-14 13:32 ` Thierry Reding 2014-01-14 17:40 ` Stephen Warren @ 2014-02-05 17:18 ` Stephen Warren 2 siblings, 0 replies; 7+ messages in thread From: Stephen Warren @ 2014-02-05 17:18 UTC (permalink / raw) To: Wolfram Sang, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: Russell King, Thierry Reding, linux-tegra-u79uwXL29TY76Z2rM5mHXA On 01/14/2014 04:58 AM, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. Applied to Tegra's for-3.15/drivers branch. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/7] drivers/gpu/host1x/drm: don't check resource with devm_ioremap_resource [not found] <1389700739-3696-1-git-send-email-wsa@the-dreams.de> [not found] ` <1389700739-3696-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> @ 2014-01-14 11:58 ` Wolfram Sang [not found] ` <1389700739-3696-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> 1 sibling, 1 reply; 7+ messages in thread From: Wolfram Sang @ 2014-01-14 11:58 UTC (permalink / raw) To: linux-kernel Cc: Wolfram Sang, Thierry Reding, Terje Bergström, David Airlie, Stephen Warren, dri-devel, linux-tegra devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> Reviewed-by: Terje Bergstrom <tbergstrom@nvidia.com> --- Should go via subsystem tree drivers/gpu/drm/tegra/hdmi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index 0cd9bc2..1650fb3 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c @@ -1375,9 +1375,6 @@ static int tegra_hdmi_probe(struct platform_device *pdev) return err; regs = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!regs) - return -ENXIO; - hdmi->regs = devm_ioremap_resource(&pdev->dev, regs); if (IS_ERR(hdmi->regs)) return PTR_ERR(hdmi->regs); -- 1.8.5.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <1389700739-3696-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]
* Re: [PATCH 3/7] drivers/gpu/host1x/drm: don't check resource with devm_ioremap_resource [not found] ` <1389700739-3696-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> @ 2014-01-14 13:40 ` Thierry Reding 0 siblings, 0 replies; 7+ messages in thread From: Thierry Reding @ 2014-01-14 13:40 UTC (permalink / raw) To: Wolfram Sang Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Terje Bergström, David Airlie, Stephen Warren, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, linux-tegra-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 494 bytes --] On Tue, Jan 14, 2014 at 12:58:54PM +0100, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> > Reviewed-by: Terje Bergstrom <tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > --- > > Should go via subsystem tree > > drivers/gpu/drm/tegra/hdmi.c | 3 --- > 1 file changed, 3 deletions(-) Applied, thanks. Thierry [-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-02-05 17:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1389700739-3696-1-git-send-email-wsa@the-dreams.de>
[not found] ` <1389700739-3696-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-01-14 11:58 ` [PATCH 2/7] drivers/amba: don't check resource with devm_ioremap_resource Wolfram Sang
[not found] ` <1389700739-3696-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-01-14 13:32 ` Thierry Reding
2014-01-14 17:40 ` Stephen Warren
[not found] ` <52D57688.8070105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-01-14 18:30 ` Wolfram Sang
2014-02-05 17:18 ` Stephen Warren
2014-01-14 11:58 ` [PATCH 3/7] drivers/gpu/host1x/drm: " Wolfram Sang
[not found] ` <1389700739-3696-3-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-01-14 13:40 ` Thierry Reding
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).