From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v2 4/6] ARM: firmware: add prepare_idle() operation Date: Thu, 13 Feb 2014 12:01:16 +0100 Message-ID: <52FCA5FC.80504@samsung.com> References: <1391747706-1847-1-git-send-email-acourbot@nvidia.com> <1391747706-1847-5-git-send-email-acourbot@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1391747706-1847-5-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Courbot , Stephen Warren , Thierry Reding , Russell King Cc: Olof Johansson , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Alexandre, On 07.02.2014 05:35, Alexandre Courbot wrote: > Some firmwares do not put the CPU into idle mode themselves, but still > need to be informed that the CPU is about to enter idle mode before this > happens. Add a prepare_idle() operation to the firmware_ops structure to > handle such cases. > > Signed-off-by: Alexandre Courbot > --- > arch/arm/include/asm/firmware.h | 4 ++++ > 1 file changed, 4 insertions(+) I wonder if .do_idle() couldn't simply return an appropriate error code to let the upper layer know that it should proceed with normal CPU idle activation, while still letting the firmware know that the CPU is going to idle. Best regards, Tomasz