From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/2] ARM: DT: fix gic interrupt controller documentation Date: Thu, 13 Mar 2014 11:44:33 -0600 Message-ID: <5321EE81.1030207@wwwdotorg.org> References: <1394732405-2260-1-git-send-email-tharvey@gateworks.com> <1394732405-2260-2-git-send-email-tharvey@gateworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394732405-2260-2-git-send-email-tharvey@gateworks.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Tim Harvey , linux-pci@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Jason Gunthorpe , Jingoo Han , Lucas Stach , Mark Rutland , linux-samsung-soc , Richard Zhu , Sascha Hauer , Arnd Bergmann , Bjorn Helgaas , Simon Horman , Thierry Reding , Ben Dooks , linux-tegra , Kukjin Kim , Shawn Guo , Grant Likely List-Id: linux-tegra@vger.kernel.org On 03/13/2014 11:40 AM, Tim Harvey wrote: > When using interrupt-maps, the size of a map entry is #address-cells + > #interrupt-cells for the parent interrupt controller. For the ARM GIC > address-cells should be 0 as this is not used. > > This patch fixes the example by correctly specifying #address-cells = 0. If the #address-cells property is required (well, or even optional...) in the node, shouldn't it be included in the list of required/optional properties above, and not solely included in the example?