From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Penny Chiu <pchiu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [cbootimage PATCH 1/2] Add Tegra124 bct data access for jtag control and chip uid
Date: Fri, 21 Mar 2014 13:50:01 -0600 [thread overview]
Message-ID: <532C97E9.6010308@wwwdotorg.org> (raw)
In-Reply-To: <1395394886-8145-2-git-send-email-pchiu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 03/21/2014 03:41 AM, Penny Chiu wrote:
...
> @@ -940,6 +941,12 @@ t124_bct_get_value(parse_token id, u_int32_t *data, u_int8_t *bct)
> + case token_unique_chip_id:
> + memcpy(data,
> + &(bct_ptr->unique_chip_id),
> + sizeof(nvboot_ecid));
> + break;
The indentation there is wrong; parameters need to be indented at least
one level more than the function they're being passed to, and I think
you can wrap at least some of them one fewer lines.
next prev parent reply other threads:[~2014-03-21 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 9:41 [cbootimage PATCH 0/2] Re-enable jtag function for Tegra124 Penny Chiu
[not found] ` <1395394886-8145-1-git-send-email-pchiu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-03-21 9:41 ` [cbootimage PATCH 1/2] Add Tegra124 bct data access for jtag control and chip uid Penny Chiu
[not found] ` <1395394886-8145-2-git-send-email-pchiu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-03-21 19:29 ` Stephen Warren
2014-03-21 19:50 ` Stephen Warren [this message]
2014-03-21 9:41 ` [cbootimage PATCH 2/2] Add update BCT configs feature Penny Chiu
[not found] ` <1395394886-8145-3-git-send-email-pchiu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-03-21 20:23 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C97E9.6010308@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=amartin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pchiu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox