From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <treding@nvidia.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Cc: linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [RFC 1/5] PCI: tegra: Overhaul regulator usage
Date: Tue, 08 Apr 2014 13:15:47 -0600 [thread overview]
Message-ID: <53444AE3.6030603@wwwdotorg.org> (raw)
In-Reply-To: <1396622969-17837-2-git-send-email-treding@nvidia.com>
On 04/04/2014 08:49 AM, Thierry Reding wrote:
> The current usage of regulators for the Tegra PCIe block is wrong. It
> doesn't accurately reflect the actual supply inputs of the IP block and
> therefore isn't as flexible as it should be. Rectify this by describing
> all possible supply inputs in the device tree binding documentation and
> deprecate the old supply properties.
> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt b/Documentation/devicetree/bindings/pci/nvidia,tegra20-pcie.txt
> +Power supplies for Tegra30:
...
> +- Optional:
> + - If port 0 is enabled:
> + - avdd-pexa-supply: Power supply for analog PCIe logic. Must supply 1.05 V.
> + - vdd-pexa-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
> + - If at least one of ports 1 and 2 is enabled:
> + - avdd-pexb-supply: Power supply for analog PCIe logic. Must supply 1.05 V.
> + - vdd-pexb-supply: Power supply for digital PCIe I/O. Must supply 1.05 V.
Did you get confirmation from HW/... that the mapping from pexa/b to
PCIe ports you document above is correct? IIRC the two supplies might be
related to lanes rather than ports?
next prev parent reply other threads:[~2014-04-08 19:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 14:49 [RFC 0/5] PCI: tegra: Overhaul regulator usage Thierry Reding
[not found] ` <1396622969-17837-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-04-04 14:49 ` [RFC 1/5] " Thierry Reding
2014-04-08 19:15 ` Stephen Warren [this message]
[not found] ` <53444AE3.6030603-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-04-08 19:52 ` Thierry Reding
2014-04-04 14:49 ` [RFC 2/5] ARM: tegra: Add new PCIe regulator properties Thierry Reding
[not found] ` <1396622969-17837-3-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-04-08 19:17 ` Stephen Warren
2014-04-08 19:54 ` Thierry Reding
2014-04-04 14:49 ` [RFC 3/5] PCI: tegra: Implement accurate power supply scheme Thierry Reding
2014-04-08 19:20 ` Stephen Warren
2014-04-08 19:55 ` Thierry Reding
2014-04-04 14:49 ` [RFC 4/5] PCI: tegra: Remove deprecated power supply properties Thierry Reding
2014-04-04 14:49 ` [RFC 5/5] ARM: tegra: Remove legacy PCIe " Thierry Reding
2014-04-08 19:21 ` [RFC 0/5] PCI: tegra: Overhaul regulator usage Stephen Warren
2014-04-25 16:57 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53444AE3.6030603@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox