[PATCH] clk: tegra124: Enable hda to hdmi clocks

[PATCH] clk: tegra124: Enable hda to hdmi clocks

[Dylan Reid]

Add the clocks used for HDMI audio played through the HDA controller.
Initialize the codec clock to 48Mhz and the HDA clock to 102MHz per
the TRM.

Signed-off-by: Dylan Reid <dgreid-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
---
 drivers/clk/tegra/clk-tegra124.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c
index 166e02f..ab15d98 100644
--- a/drivers/clk/tegra/clk-tegra124.c
+++ b/drivers/clk/tegra/clk-tegra124.c
@@ -1018,6 +1018,9 @@ static struct tegra_devclk devclks[] __initdata = {
 	{ .con_id = "fuse", .dt_id = TEGRA124_CLK_FUSE },
 	{ .dev_id = "rtc-tegra", .dt_id = TEGRA124_CLK_RTC },
 	{ .dev_id = "timer", .dt_id = TEGRA124_CLK_TIMER },
+	{ .con_id = "hda", .dt_id = TEGRA124_CLK_HDA },
+	{ .con_id = "hda2codec_2x", .dt_id = TEGRA124_CLK_HDA2CODEC_2X },
+	{ .con_id = "hda2hdmi", .dt_id = TEGRA124_CLK_HDA2HDMI },
 };
 
 static struct clk **clks;
@@ -1371,6 +1374,8 @@ static struct tegra_clk_init_table init_table[] __initdata = {
 	{TEGRA124_CLK_SBC4, TEGRA124_CLK_PLL_P, 12000000, 1},
 	{TEGRA124_CLK_TSEC, TEGRA124_CLK_PLL_C3, 0, 0},
 	{TEGRA124_CLK_MSENC, TEGRA124_CLK_PLL_C3, 0, 0},
+	{TEGRA124_CLK_HDA, TEGRA124_CLK_PLL_P, 102000000, 0},
+	{TEGRA124_CLK_HDA2CODEC_2X, TEGRA124_CLK_PLL_P, 48000000, 0},
 	/* This MUST be the last entry. */
 	{TEGRA124_CLK_CLK_MAX, TEGRA124_CLK_CLK_MAX, 0, 0},
 };
-- 
1.8.1.3.605.g02339dd

Re: [PATCH] clk: tegra124: Enable hda to hdmi clocks

[Stephen Warren]

On 04/08/2014 01:17 PM, Dylan Reid wrote:
> Add the clocks used for HDMI audio played through the HDA controller.
> Initialize the codec clock to 48Mhz and the HDA clock to 102MHz per
> the TRM.

This patch seems fine to me. Peter, I assume you'll apply this and
eventually sent a pull request to Mike.

Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Re: [PATCH] clk: tegra124: Enable hda to hdmi clocks

[Takashi Iwai]

At Tue, 15 Apr 2014 12:19:06 -0600,
Stephen Warren wrote:
> 
> On 04/08/2014 01:17 PM, Dylan Reid wrote:
> > Add the clocks used for HDMI audio played through the HDA controller.
> > Initialize the codec clock to 48Mhz and the HDA clock to 102MHz per
> > the TRM.
> 
> This patch seems fine to me. Peter, I assume you'll apply this and
> eventually sent a pull request to Mike.
> 
> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

I guess this is basically needed for Tegra HD-audio HDMI stuff, so I'd
need to pull the change to my branch once when applying other Dylan's
patches.  Let me know the pull-able branch once when merged.
Alternatively, I can apply the all patches in series to my tree if
it's easier, too.  Just let me know what you guys prefer.

(BTW, Dylan, v3 patches haven't been submitted yet, right?)


thanks,

Takashi

Re: [PATCH] clk: tegra124: Enable hda to hdmi clocks

[Stephen Warren]

On 04/16/2014 08:30 AM, Takashi Iwai wrote:
> At Tue, 15 Apr 2014 12:19:06 -0600,
> Stephen Warren wrote:
>>
>> On 04/08/2014 01:17 PM, Dylan Reid wrote:
>>> Add the clocks used for HDMI audio played through the HDA controller.
>>> Initialize the codec clock to 48Mhz and the HDA clock to 102MHz per
>>> the TRM.
>>
>> This patch seems fine to me. Peter, I assume you'll apply this and
>> eventually sent a pull request to Mike.
>>
>> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> I guess this is basically needed for Tegra HD-audio HDMI stuff, so I'd
> need to pull the change to my branch once when applying other Dylan's
> patches.  Let me know the pull-able branch once when merged.
> Alternatively, I can apply the all patches in series to my tree if
> it's easier, too.  Just let me know what you guys prefer.

This change is only needed at run-time, not at compile-time, so there's
no build-time dependency. Since this is a new feature, it's fine for it
to only work once everything is merged together in linux-next, or
Linus's tree, so there's to push it all through a single branch.

Re: [PATCH] clk: tegra124: Enable hda to hdmi clocks

[Takashi Iwai]

At Wed, 16 Apr 2014 09:55:01 -0600,
Stephen Warren wrote:
> 
> On 04/16/2014 08:30 AM, Takashi Iwai wrote:
> > At Tue, 15 Apr 2014 12:19:06 -0600,
> > Stephen Warren wrote:
> >>
> >> On 04/08/2014 01:17 PM, Dylan Reid wrote:
> >>> Add the clocks used for HDMI audio played through the HDA controller.
> >>> Initialize the codec clock to 48Mhz and the HDA clock to 102MHz per
> >>> the TRM.
> >>
> >> This patch seems fine to me. Peter, I assume you'll apply this and
> >> eventually sent a pull request to Mike.
> >>
> >> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> > 
> > I guess this is basically needed for Tegra HD-audio HDMI stuff, so I'd
> > need to pull the change to my branch once when applying other Dylan's
> > patches.  Let me know the pull-able branch once when merged.
> > Alternatively, I can apply the all patches in series to my tree if
> > it's easier, too.  Just let me know what you guys prefer.
> 
> This change is only needed at run-time, not at compile-time, so there's
> no build-time dependency. Since this is a new feature, it's fine for it
> to only work once everything is merged together in linux-next, or
> Linus's tree, so there's to push it all through a single branch.

This fix seems still missing in linux-next.  Note that the whole Tegra
HDMI audio driver patches have been already included in for-next
branch of sound git tree.


Takashi

Re: [PATCH] clk: tegra124: Enable hda to hdmi clocks

[Dylan Reid]

On Mon, Jun 2, 2014 at 5:45 AM, Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org> wrote:
> At Wed, 16 Apr 2014 09:55:01 -0600,
> Stephen Warren wrote:
>>
>> On 04/16/2014 08:30 AM, Takashi Iwai wrote:
>> > At Tue, 15 Apr 2014 12:19:06 -0600,
>> > Stephen Warren wrote:
>> >>
>> >> On 04/08/2014 01:17 PM, Dylan Reid wrote:
>> >>> Add the clocks used for HDMI audio played through the HDA controller.
>> >>> Initialize the codec clock to 48Mhz and the HDA clock to 102MHz per
>> >>> the TRM.
>> >>
>> >> This patch seems fine to me. Peter, I assume you'll apply this and
>> >> eventually sent a pull request to Mike.
>> >>
>> >> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> >
>> > I guess this is basically needed for Tegra HD-audio HDMI stuff, so I'd
>> > need to pull the change to my branch once when applying other Dylan's
>> > patches.  Let me know the pull-able branch once when merged.
>> > Alternatively, I can apply the all patches in series to my tree if
>> > it's easier, too.  Just let me know what you guys prefer.
>>
>> This change is only needed at run-time, not at compile-time, so there's
>> no build-time dependency. Since this is a new feature, it's fine for it
>> to only work once everything is merged together in linux-next, or
>> Linus's tree, so there's to push it all through a single branch.
>
> This fix seems still missing in linux-next.  Note that the whole Tegra
> HDMI audio driver patches have been already included in for-next
> branch of sound git tree.

Thanks for checking Takashi,

I thought it was going through Peter's tree.  Peter have you had a
chance to take a look?

Thanks,

Dylan

>
>
> Takashi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] clk: tegra124: Enable hda to hdmi clocks

[Dylan Reid]

On Wed, Apr 16, 2014 at 7:30 AM, Takashi Iwai <tiwai-l3A5Bk7waGM@public.gmane.org> wrote:
> At Tue, 15 Apr 2014 12:19:06 -0600,
> Stephen Warren wrote:
>>
>> On 04/08/2014 01:17 PM, Dylan Reid wrote:
>> > Add the clocks used for HDMI audio played through the HDA controller.
>> > Initialize the codec clock to 48Mhz and the HDA clock to 102MHz per
>> > the TRM.
>>
>> This patch seems fine to me. Peter, I assume you'll apply this and
>> eventually sent a pull request to Mike.
>>
>> Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> I guess this is basically needed for Tegra HD-audio HDMI stuff, so I'd
> need to pull the change to my branch once when applying other Dylan's
> patches.  Let me know the pull-able branch once when merged.
> Alternatively, I can apply the all patches in series to my tree if
> it's easier, too.  Just let me know what you guys prefer.
>
> (BTW, Dylan, v3 patches haven't been submitted yet, right?)

I'll send it out later today, found a runtime pm bug that I want to fix first.

Thanks,

Dylan

>
>
> thanks,
>
> Takashi